Skip to content

fix: deduplicate fields to prevent Elixir 1.20 redundant clause warnings#648

Merged
woylie merged 1 commit into
woylie:mainfrom
allocator-one:fix/deduplicate-schema-fields
Mar 12, 2026
Merged

fix: deduplicate fields to prevent Elixir 1.20 redundant clause warnings#648
woylie merged 1 commit into
woylie:mainfrom
allocator-one:fix/deduplicate-schema-fields

Conversation

@aptinio
Copy link
Copy Markdown
Contributor

@aptinio aptinio commented Mar 12, 2026

When a join or alias field shares a name with a schema field, fields/2 returns duplicate entries, causing redundant clause warnings in the generated field_info/2 and get_field/2 functions on Elixir 1.20.

@aptinio aptinio requested a review from woylie as a code owner March 12, 2026 06:21
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@aptinio aptinio force-pushed the fix/deduplicate-schema-fields branch from 6f1100b to e7f04ae Compare March 12, 2026 06:28
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.45%. Comparing base (bb96018) to head (e7f04ae).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #648      +/-   ##
==========================================
+ Coverage   84.44%   84.45%   +0.01%     
==========================================
  Files          15       15              
  Lines        1022     1023       +1     
==========================================
+ Hits          863      864       +1     
  Misses        159      159              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@woylie woylie merged commit 2b81566 into woylie:main Mar 12, 2026
20 checks passed
@woylie
Copy link
Copy Markdown
Owner

woylie commented Mar 12, 2026

Thank you!

@aptinio aptinio deleted the fix/deduplicate-schema-fields branch March 12, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants