Skip to content

fix(flop-validation): reset conflicting pagination fields if replace_invalid_params is true#654

Merged
woylie merged 4 commits into
woylie:mainfrom
shunjilin:fix/mixing-invalid-pagination-types
May 18, 2026
Merged

fix(flop-validation): reset conflicting pagination fields if replace_invalid_params is true#654
woylie merged 4 commits into
woylie:mainfrom
shunjilin:fix/mixing-invalid-pagination-types

Conversation

@shunjilin
Copy link
Copy Markdown
Contributor

There is an issue where if conflicting pagination types are set, and if at least one of them is malformed (e.g. not an integer), the Flop.validate function returns an {error, changeset} tuple even if replace_invalid_params is set to true.

This is an attempt to fix by ensuring that all conflicting pagination fields are reset if there is a conflict and replace_invalid_params is set to true.

@shunjilin shunjilin requested a review from woylie as a code owner April 1, 2026 06:23
@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.45%. Comparing base (1ad0d9f) to head (3526e1c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
+ Coverage   84.41%   84.45%   +0.04%     
==========================================
  Files          15       15              
  Lines        1033     1036       +3     
==========================================
+ Hits          872      875       +3     
  Misses        161      161              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@woylie woylie merged commit 28b831c into woylie:main May 18, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants