-
Notifications
You must be signed in to change notification settings - Fork 814
WRF-urban-NbS development #2272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-v4.7.1
Are you sure you want to change the base?
Conversation
WRF-urban-nbs update
Update dyn_em files with new WRF-urban-nbs related variables
Largely enhanced module_sf_urban.F to incorporate nature-based solutions (including urban trees) Update phys files with new WRF-urban-nbs related variables
Update TBL files with new WRF-urban-nbs related variables
Update wrftladj files with new WRF-urban-nbs related variables
|
This PR will fail the regression test because the NoahMP link has not been updated yet. The developers are working to update the noahmp github for this changes and will update the commit soon once the noahmp link is updated. |
|
@chenghaow This PR fails for multiple tests when |
- Removed double-precision-related code based on HRLDAS offline model - Uncommented distributed aerodynamic roughness length related code to be consistent with WRF v4.7.1
|
@weiwangncar Thanks for sharing the compilation log. We found that the issue is caused by an inconsistency in @cenlinhe I'll open a separate issue in the HRLDAS repo on this. |
|
yes, Noah-MP uses a different double precision flag (DOUBLE_PREC) than WRF (DOUBLE_PRECISION). My NoahMPv5 coupling will resolve this issue, but it's good that you reverted back to the original WRF-Urban treatment. Please make sure that you did not remove any other default urban code in the WRF version (do not use HRLDAS version). |
Sure. We will keep the double precision flag in the offline version though. |
|
HRLDAS version of the urban code may lag a few recent WRF-Urban updates. |
Duplicate declarations removed
|
The current version successfully compiled on Derecho with |
|
@chenghaow The last regression tests failed on three cases. Attached is the output file from this group of tests (search for kiaps2): |
Also removed temporary fix for singularity matrix in tree energy budget
|
This PR needs to be merged first before the refactored NoahMP coupling PR (#2268) because this PR modifies the non-refactored NoahMP urban driver. Once this urban PR is merged, I will need to update the Noah-MP urban driver in the refactored code and hence the refactored NoahMP coupling PR above to avoid any merge conflicts. |
|
@weiwangncar Looks like our recent fix failed the regression tests. Would you please share the output file? Thanks! |
|
@chenghaow See attached file here (tests for kiaps2 namelists): |
Singular matrix in Urban Tree Energy Budget
Stabilize urban tree energy budget solve with damped diagonal fallback
|
@chenghaow The last commit caused failed compilation with errors like these: |
Bug fix as of Jan 20, 2026
|
Hi @weiwangncar We just fixed some unit-related bugs, but this updated version failed the regression tests. Our compilation succeeded on Derecho, though. Would you please share the output file when you have a moment? Thanks. |
|
@chenghaow The latest commit failed the same tests. Here is the output: |
|
@chenghaow To compile KIAPS radiation option, edit configure.wrf, and search for -DBUILD_RRTMK=0, and changes the value to 1. |
|
@chenghaow On Derecho, you can find the data used by regression test in /glade/derecho/scratch/weiwang/Data/em_real/. |
|
@chenghaow The last commit resulted in only one run failure: the MPI run using namelist.input.kiaps2. The serial and OpenMP runs have completed. |
Development of the WRF-urban-NbS module within the single-layer urban canopy model
TYPE: new feature
KEYWORDS: urban canopy models, urban trees, nature-based solutions, urban grass, urban hydrology, radiative view factors
SOURCE: Yuqi Huang (University of Oklahoma), Chenghao Wang (University of Oklahoma), Cenlin He (NCAR)
DESCRIPTION OF CHANGES:
Problem: The current WRF-urban modeling system employs a single-layer urban canopy model (SLUCM) that assumes a dry street canyon. While a green roof module exists, ground vegetation and street trees are not represented. As a result, key nature-based solution (NbS) processes such as evapotranspiration, radiative shading, and soil–vegetation–atmosphere interactions are not captured. In addition, radiative exchanges involving trees are not explicitly resolved. A version of the urban tree module within SLUCM was developed and tested for the contiguous U.S. but only accounted for shading in a simplified way:
Solution:
This PR introduces urban ground vegetation and street trees into the single-layer urban canopy model. Round-shaped urban trees are explicitly represented, resolving evapotranspiration, shading, and root water uptake. Radiative exchanges between trees and surrounding urban elements are solved using newly implemented analytical view factors.
The development is largely based on the Arizona State University Single-Layer Urban Canopy Model (ASLUM v3.1) and its hydrologically enhanced version, ASLUM-Hydro, and extends their capabilities within the WRF-Urban framework. See the following two papers for ASLUM v3.1 and ASLUM-Hydro:
ISSUE: NA
LIST OF MODIFIED FILES:
The following files were modified (generated using
git diff --name-only master urban_nbs):TESTS CONDUCTED:
Note:
Successful compilation requires Noah-MP-related source files that are not included in WRF v3.7.1, including a modified version of
module_sf_noahmpdrv.F. These changes will be addressed in a separate PR dedicated to Noah-MP.RELEASE NOTE:
Manuscripts in development: