Updated MYNN surface layer submodule #2277
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the old MYNN surface layer scheme and adds the new modularized submodule version. The scheme from the CCPP was used as the initial form but it has decomposed into 3 different modules for land, water, and ice. Some other changes (noted below) were made to accommodate this new version.
TYPE: bug fix, enhancement, new submodule version
KEYWORDS: MYNN-SFC, submodule
SOURCE: Joseph Olson (NOAA-GSL) and Xia Sun (NOAA-GSL)
DESCRIPTION OF CHANGES:
Problem:
Solution:
LIST OF MODIFIED FILES: list of changed files (use
git diff --name-status masterto get formatted list)M .gitmodules
M Makefile
M Registry/Registry.EM_COMMON
M dyn_em/module_first_rk_step_part1.F
M main/depend.common
M phys/CMakeLists.txt
A phys/MYNN-SFC
M phys/Makefile
M phys/module_physics_init.F
D phys/module_sf_mynn.F
M phys/module_surface_driver.F
TESTS CONDUCTED:
RELEASE NOTE:
The MYNN surface layer scheme has been updated to the new modularized submodule version. The original form of this version was taken from the CCPP but it has been decomposed into 3 different modules for land, water, and ice. This helps to centralize all future development in submodule repository that will soon hook up to all models (WRF, MPAS, CCPP). Some minor bug fixes have been implemented, including a fix for using SPP in the water submodule. New MYNN-specific options (sf_mynnsfc_sfcflux_land and sf_mynnsfc_sfcflux_water) have been added to replace the shared options (iz0tlnd and isftcflx) that carried different meaning for different surface layer schemes.