Fix value references to imagePullPolicy

[schaer-bgs]

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues in the following format: The imagePullPolicy setting is not applied to the deployment.

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email documentation@wso2.com to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

• Unit tests

  Code coverage information

• Integration tests

  Details about the test cases and coverage

Security checks

• Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes/no
• Ran FindSecurityBugs plugin and verified report? yes/no
• Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes/no

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

Summary by CodeRabbit

• Chores
  • Added Helm 3 as a tooling requirement
  • Updated Kubernetes deployment configurations to reference a restructured Helm values hierarchy for image pull policy settings across all service components

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[coderabbitai]

Walkthrough

This pull request adds a Helm/mise tooling configuration and standardizes imagePullPolicy value paths across multiple Kubernetes deployment templates. The imagePullPolicy references are refactored from .Values.wso2.deployment.imagePullPolicy to the nested path .Values.wso2.deployment.image.imagePullPolicy for consistency.

Changes

Cohort / File(s)	Summary
Configuration & Tooling all-in-one/mise.toml	Added new configuration file specifying Helm 3 as a tooling requirement.
Helm Deployment Templates – imagePullPolicy Refactoring all-in-one/templates/am/instance-1/wso2am-deployment.yaml, all-in-one/templates/am/instance-2/wso2am-deployment.yaml, distributed/control-plane/templates/control-plane/instance-1/wso2am-cp-deployment.yaml, distributed/control-plane/templates/control-plane/instance-2/wso2am-cp-deployment.yaml, distributed/gateway/templates/gateway/wso2am-gateway-deployment.yaml, distributed/key-manager/templates/key-manager/wso2am-km-deployment.yaml, distributed/traffic-manager/templates/traffic-manager/instance-1/wso2am-tm-deployment.yaml, distributed/traffic-manager/templates/traffic-manager/instance-2/wso2am-tm-deployment.yaml	Standardized imagePullPolicy field references to use nested .Values.wso2.deployment.image.imagePullPolicy path across all deployment manifests. Minor template syntax fixes applied to instance-2 files.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Hop, hop—the paths now unified!
From shallow to nested, all neatly aligned,
Helm values cascade down the tree,
A garden of config, tidy and free!
Eight deployments dancing in perfect refrain, 🌱

🚥 Pre-merge checks | ✅ 2 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is largely incomplete. Only the Purpose section contains meaningful content; all other required sections (Goals, Approach, User stories, Release note, Documentation, Training, Certification, Marketing, Automation tests, Security checks, Samples, Related PRs, Migrations, Test environment, Learning) remain as empty template placeholders.	Complete the required sections in the PR description, particularly Goals (how the fix resolves the issue), Approach (implementation details), and whether tests were performed. Mark sections as 'N/A' with explanations where not applicable.
Merge Conflict Detection	⚠️ Warning	❌ Merge conflicts detected (8 files): ⚔️ all-in-one/templates/am/instance-1/wso2am-deployment.yaml (content) ⚔️ all-in-one/templates/am/instance-2/wso2am-deployment.yaml (content) ⚔️ distributed/control-plane/templates/control-plane/instance-1/wso2am-cp-deployment.yaml (content) ⚔️ distributed/control-plane/templates/control-plane/instance-2/wso2am-cp-deployment.yaml (content) ⚔️ distributed/gateway/templates/gateway/wso2am-gateway-deployment.yaml (content) ⚔️ distributed/key-manager/templates/key-manager/wso2am-km-deployment.yaml (content) ⚔️ distributed/traffic-manager/templates/traffic-manager/instance-1/wso2am-tm-deployment.yaml (content) ⚔️ distributed/traffic-manager/templates/traffic-manager/instance-2/wso2am-tm-deployment.yaml (content) These conflicts must be resolved before merging into main.	Resolve conflicts locally and push changes to this branch.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: fixing imagePullPolicy value references across multiple deployment templates.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

⚔️ Resolve merge conflicts (beta)

• Auto-commit resolved conflicts to branch bugfix/image-pull-policy
• Post resolved changes as copyable diffs in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

distributed/key-manager/templates/key-manager/wso2am-km-deployment.yaml (1)

156-169: ⚠️ Potential issue | 🟠 Major

Pre-existing bug: duplicate livenessProbe, missing readinessProbe.

Lines 156–162 and 163–169 both define livenessProbe. The second one silently overwrites the first in YAML. It looks like one of these should be readinessProbe. This is not introduced by this PR but is worth fixing while you're in this file.

🧹 Nitpick comments (1)

all-in-one/mise.toml (1)

1-2: Unrelated to the imagePullPolicy fix.

This file appears to be a local tooling configuration (mise.toml) unrelated to the bug fix. Consider separating it into its own commit or PR to keep the change focused.