Update mLib and Eigen to fix compile errors#2
Open
ybh1998 wants to merge 5 commits into
Open
Conversation
… user has DirectX SDK installed, these path may override Windows SDK version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update mLib for following reasons:
BoundingBox2 class in old mLib has union members but don't have a copy constructor, which causes compilation errors.
D3DX11CompileFromFile should be replaced by D3DCompileFromFile to remove DirectX SDK dependencies.
Eigen in mLibExternal is not compatible with new Visual Studio. Update to 3.2.10 by override include path.