save assistant messages as EventNewAssistantMessage instead of EventNewToken#27
Merged
save assistant messages as EventNewAssistantMessage instead of EventNewToken#27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sessionwas appending the collected assistant response to chat history asNewEventNewTokeninstead ofNewEventNewAssistantMessage. Since theSyncInputcontract explicitly states that streaming-only events (includingEventNewToken) should not be synced to client params, providers were silently dropping the assistant's turns — making the model appear to have no memory of its own responses.Changes
handleCompletionEndnow appendsNewEventNewAssistantMessageinstead ofNewEventNewTokenSyncInputandAppendEventcontracts documented explicitly intypes.goandhelpers.goTestSession_CollectsTokensupdated to assert onEventNewAssistantMessageCloses #26