fix: initialize nil Messages and Tools in Chat via ensureDefaults#31
Merged
fix: initialize nil Messages and Tools in Chat via ensureDefaults#31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30
Summary
Chatstruct allows partial initialization — omittingMessagesorToolsis valid Go, but caused a nil pointer panic on the first call toSession. Since the zero value of a struct should be as useful as possible, the fix initializes missing fields lazily at the entry point rather than forcing callers to provide them.Changes
ensureDefaults()added tochat.go, called at the top ofSession()Unit tests covering nil
Messages, nilTools, both nil, and preservation of existing values