Conversation
make NewTools return *Tools for consistency with NewMessages
fix: initialize nil Messages and Tools in Chat via ensureDefaults
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two related improvements to
Chatinitialization and API consistency.Fix: Chat panics without Tools field (#30)
Chat{}withoutToolscaused a nil pointer panic on the firstSession()call.ensureDefaults()now initializes missingMessagesandToolslazily at the entry point — existing values are never overwritten.Refactor: consistent constructors
NewTools()previously returnedToolsby value, whileNewMessages()returned*Messages— forcing callers to manually take&toolList. Both types contain a mutex internally, so returning by pointer is correct regardless. Now both constructors return a pointer.Closes #30