Closed
Conversation
Collaborator
Contributor
Author
|
@maks Done. |
maks
requested changes
Apr 2, 2026
maks
requested changes
Apr 9, 2026
Collaborator
maks
left a comment
maks
left a comment
There was a problem hiding this comment.
@n1LS Apart from specific code feedback the biggest problem with this PR is that it nor its preceeding PR #1274 had no matching issue where the required functionality and performance was discussed and agreed upon. Because of that I will be closing this PR and the prior draft, either can either be reopened or a new one done in the future only once a matching issue is ready for implementation.
| const char *filter, bool subDirOnly, | ||
| bool includeHidden) { | ||
| const char *filter, ListFlags flags) { | ||
| bool subDirOnly = flags & LF_SUBDIRS_ONLY; |
Collaborator
There was a problem hiding this comment.
@n1LS no the point from my previous feedback was not to consolidate the bool params, my point is that we dont want to change the interface of list. If that requires adding a new listSorted() then please do that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #1283, this implements #1274