Skip to content

improves textfield handling#1304

Open
n1LS wants to merge 2 commits intoxiphonics:masterfrom
n1LS:improve-textfield
Open

improves textfield handling#1304
n1LS wants to merge 2 commits intoxiphonics:masterfrom
n1LS:improve-textfield

Conversation

@n1LS
Copy link
Copy Markdown
Contributor

@n1LS n1LS commented Feb 27, 2026

Implements #1302

@maks maks self-requested a review March 20, 2026 07:08
Copy link
Copy Markdown
Collaborator

@maks maks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for remembering the last entered character but we can't use EDIT_ENTER+UP/DOWN for jumping through char ranges because on screens with the waveform display that is already used for zoom in/out.

Comment thread sources/Application/Views/BaseClasses/UITextField.ipp Outdated
@n1LS
Copy link
Copy Markdown
Contributor Author

n1LS commented Mar 20, 2026

This looks good for remembering the last entered character but we can't use EDIT_ENTER+UP/DOWN for jumping through char ranges because on screens with the waveform display that is already used for zoom in/out.

Suggestions? UIField doesn't get all key presses, so - depending on the combo - we either need to make due with what we have or extend the UIField to have broader access to the input.

Comment thread sources/Application/Views/BaseClasses/UITextField.ipp Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants