IRT triggers note step in instrument automation tables

[maks]

The issue description covers in detail the reason for this change and the results.

Note the memcpy's needed to be added to SIDInstrument because they were missing where Sample & MIDI had them while OPAL has not table support at all yet.

Fixes: #1368

[democloid]

I honestly don't feel confident enough in reviewing this code and be able to judge if it would work. Can we add test coverage in order to cover the different scenarios? That will also help explain what the different scenarios are.

[maks]

I honestly don't feel confident enough in reviewing this code and be able to judge if it would work. Can we add test coverage in order to cover the different scenarios? That will also help explain what the different scenarios are.

I'll try to add test coverage but not sure if it will be possible without a huge amount of test harness setup. will see what I can do.
More immediately, I'll record and attach, videos showing the difference with this change vs current behaviour.

[maks]

@democloid here is the current master:

no-table-irt.mp4

while here is this branch again with exactly the same project file:

with-table-irt.mp4

You can see that in first case the automation table 01 on the instrumetn is only triggered by the initial note on the phrase screen, not by the IRT command that causes retriggers (on table 4) while in the 2nd video the IRT triggered notes also cause the automation table to step.

[democloid]

@maks But, there is no IRT command here?

[maks]

@maks But, there is no IRT command here?

@democloid sorry I should have shown the table assigned to the step in the phrase, which is where the IRT is because its a table only command. I didnt show it because its literally only a table with a single IRT command on first row. The key thing here though is that the automation table is not being triggered by the IRT currently.

[maks]

Project showing use of IRT to trigger automation table:
IrT.zip

[maks]

approved offline.