Skip to content

Show Fred version from Gradle script#4

Open
bertm wants to merge 1 commit into
xor-freenet:nextfrom
bertm:gradle-show-fred-version
Open

Show Fred version from Gradle script#4
bertm wants to merge 1 commit into
xor-freenet:nextfrom
bertm:gradle-show-fred-version

Conversation

@bertm
Copy link
Copy Markdown

@bertm bertm commented Jun 29, 2025

The workflow used to rely on Fred's freenet.node.Version having a main(...) method that prints the version information. That method has been removed, breaking this build.

Compile a version string in Gradle by invoking the related methods on the Version class.

The workflow used to rely on Fred's freenet.node.Version having a main(...)
method that prints the version information. That method has been removed,
breaking this build.

Compile a version string in Gradle by invoking the related methods on the
Version class.
@bertm bertm force-pushed the gradle-show-fred-version branch from 62588be to 3e0f0f8 Compare June 29, 2025 15:31
@bertm
Copy link
Copy Markdown
Author

bertm commented Jun 29, 2025

@xor-freenet nice to see you're still active - here's a potential fix for the recent CI breakage.

@xor-freenet
Copy link
Copy Markdown
Owner

@bertm Oh hello! :) I am also really happy you're still contributing, and also to see you back as a person in general :)
In fact I had already seen that you came back while passively watching fred PRs and was happy about that already!
I had mailed you some times already, but got no reply and I wasn't sure whether your Gmail silently drops my mails or you didn't want to talk to me. So I decided to leave it at that.
Do you want to establish a way for private conversations?
Are you on the FMS board "freenet"?

Regarding your PRs:

  • This one: Thanks very much :) I don't have time to look into it right now, will do the following days.
  • The old one "Cleanup event generics": For a long time I wanted to let you know that I have NOT forgotten about that one. The event-notifications API is currently just not the top priority, the priority is finishing the IdentityFetcher-rewrite which I have been working on for 85 branches now. Given it's been taking that many branches and thus that much time I do not want to get distracted too much, hence I've put the "Cleanup event generics" PR on hold.
    I couldn't explain that on Hyphanet's WoT repo because our peace agreement stipulates that I don't comment there.
    I had thus created a duplicate of the PR on my repository, see Cleanup event generics #1 .
    Could you please close the original one on Hyphanet's WoT repo so people don't wrongly think I've forgotten about it?
    It's linked inside my copy of the PR.

Thanks very much again :)

@xor-freenet
Copy link
Copy Markdown
Owner

@bertm Did you intentionally delete your last comment here or does GitHub now randomly drop comments?!?
I do still have a copy from the email notification so I will be able to reply once I'm at the mail client again :)
Meanwhile FYI: I haven't forgotten about this new PR either, I just want to finish something else first which Arne has requested (i.e. do a small WoT release to just update the seed identities).

@bertm
Copy link
Copy Markdown
Author

bertm commented Aug 8, 2025

@xor-freenet I sent you an email to address the off-topic matters. Let's keep this PR's discussion focused on the PR itself 😃

@xor-freenet
Copy link
Copy Markdown
Owner

@bertm Thanks but I did not get the mail, not even in the spam folder :( Do you have a different mail address you could try sending it from?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants