fix: align cosmossdk core requirement#134
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated ChangesDependency Version & Override Cleanup
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.11.4)Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
fix: align cosmossdk core requirement
Motivation 💡
cosmossdk.io/coredowngrade wherego.modrequiredv0.12.0but resolvedv0.11.3through a replace directive.cosmossdk.io/core v0.12.0, which is retracted and incompatible with the Cosmos SDK fork used by this repository.Changes 🛠
cosmossdk.io/corerequirement fromv0.12.0tov0.11.3.cosmossdk.io/core => cosmossdk.io/core v0.11.3replace directive and rosetta workaround comment.Considerations 🤔
go list -m -json -retracted cosmossdk.io/core@v0.12.0reports thatv0.12.0was tagged too early and is incompatible with Cosmos SDKv0.50.v0.12.0renamescomet.BlockInfotocomet.Info, which breaks the currentgithub.com/xrplevm/cosmos-sdk v0.53.6-xrplevm.1dependency.Summary by CodeRabbit