Skip to content

refactor: remove unused poa gov keeper#137

Merged
AdriaCarrera merged 3 commits into
mainfrom
refactor/remove-unused-poa-govkeeper
May 13, 2026
Merged

refactor: remove unused poa gov keeper#137
AdriaCarrera merged 3 commits into
mainfrom
refactor/remove-unused-poa-govkeeper

Conversation

@kpitapeersyst
Copy link
Copy Markdown
Contributor

@kpitapeersyst kpitapeersyst commented May 4, 2026

refactor: remove unused poa gov keeper

Motivation 💡

  • Remove an unused PoA keeper dependency.

Changes 🛠

  • Removed GovKeeper from the PoA expected keepers.
  • Removed the generated MockGovKeeper mock.

Summary by CodeRabbit

  • Chores
    • Removed unused governance mock and related interface from test utilities.
    • Cleaned up now-unnecessary imports and simplified internal simulation surfaces.
    • Reduced test scaffolding to streamline maintenance and reviews.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3242362a-c4f5-4284-bd51-a312c2df2ecf

📥 Commits

Reviewing files that changed from the base of the PR and between 9799dec and d565c96.

📒 Files selected for processing (1)
  • x/poa/testutil/expected_keepers_mock.go

📝 Walkthrough

Walkthrough

Removes the exported GovKeeper interface and the generated MockGovKeeper (and their gov v1 imports) from the POA module's expected keepers and test utilities.

Changes

Gov Keeper Interface and Mock Removal

Layer / File(s) Summary
Interface removal
x/poa/types/expected_keepers.go
Deletes the GovKeeper interface and removes the github.com/cosmos/cosmos-sdk/x/gov/types/v1 import.
Mock removal
x/poa/testutil/expected_keepers_mock.go
Removes MockGovKeeper and MockGovKeeperMockRecorder (constructor, EXPECT, SubmitProposal mock/recorder) and deletes the now-unused gov v1 import.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • xrplevm/node#137: Main PR deletes the same PoA GovKeeper interface and its generated MockGovKeeper (SubmitProposal) from x/poa/types/expected_keepers.go and x/poa/testutil/expected_keepers_mock.go.
  • xrplevm/node#130: Modifies the POA keeper mock surface related to MockGovKeeper/SubmitProposal.

Suggested reviewers

  • AdriaCarrera

"🐰 I hopped through code, trimmed what was spare,
A keeper and mock vanished into thin air.
POA breathes lighter, tests stay neat,
I twitch my nose — a tidy feat! 🥕"

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'refactor: remove unused poa gov keeper' clearly and concisely summarizes the main change: removing an unused GovernanceKeeper from the PoA module.
Description check ✅ Passed The description follows the template with Motivation and Changes sections completed. The Dependencies section is omitted as not applicable, and Considerations is not included but not critical.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/remove-unused-poa-govkeeper

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AdriaCarrera AdriaCarrera merged commit 216a087 into main May 13, 2026
4 of 5 checks passed
@AdriaCarrera AdriaCarrera deleted the refactor/remove-unused-poa-govkeeper branch May 13, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants