-
Notifications
You must be signed in to change notification settings - Fork 56
Add Telegram Group & Fix Warnings #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -260,6 +260,7 @@ object DirectSignsChecker { | |
| return SignalOutcome(detected = detected, needsReview = needsReview) | ||
| } | ||
|
|
||
| @Suppress("DEPRECATION") | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ? |
||
| private fun collectProxyInfoProfiles(context: Context): ProxyProfileCollection { | ||
| val cm = context.getSystemService(Context.CONNECTIVITY_SERVICE) as ConnectivityManager | ||
|
|
||
|
|
@@ -734,7 +735,7 @@ object DirectSignsChecker { | |
| val hasDnsPathMismatch = comparison?.dnsPathMismatch == true | ||
| if (hasDnsPathMismatch) { | ||
| val transportOnly = comparison!!.usedCurlCompatibleFallback() && | ||
| comparison!!.curlCompatible!!.transportDiagnostics.resolveStrategy != TunProbeResolveStrategy.KOTLIN_INJECTED | ||
| comparison.curlCompatible.transportDiagnostics.resolveStrategy != TunProbeResolveStrategy.KOTLIN_INJECTED | ||
| val confidence = if (transportOnly) EvidenceConfidence.MEDIUM else EvidenceConfidence.HIGH | ||
| evidence.add( | ||
| EvidenceItem( | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -333,8 +333,7 @@ object IndirectSignsChecker { | |
| capsString = capsString, | ||
| routes = linkProperties.routes.map { route -> | ||
| RouteSnapshot( | ||
| destination = route.destination?.toString() | ||
| ?: if (route.isDefaultRoute) "0.0.0.0/0" else "unknown", | ||
| destination = route.destination.toString(), | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Потенциальная потеря fallback-логики "0.0.0.0/0"/"unknown" |
||
| gateway = route.gateway?.hostAddress?.takeUnless { it == "0.0.0.0" || it == "::" }, | ||
| interfaceName = NetworkInterfaceNameNormalizer.canonicalName( | ||
| route.`interface` ?: linkProperties.interfaceName, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| @file:Suppress("DEPRECATION") | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. так нельзя делать, на весь файл suppress не вешают |
||
|
|
||
| package com.notcvnt.rknhardering.checker | ||
|
|
||
| import android.Manifest | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -178,7 +178,7 @@ object VpnCheckRunner { | |
| } | ||
|
|
||
| private object Fallbacks { | ||
| fun geoIp(context: Context, error: Throwable): CategoryResult = CategoryResult( | ||
| fun geoIp(@Suppress("UNUSED_PARAMETER") context: Context, error: Throwable): CategoryResult = CategoryResult( | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. если unused то убирать надо, а не глушить warning |
||
| name = "GeoIP", | ||
| detected = false, | ||
| findings = listOf(Finding(error.message ?: error::class.java.simpleName, isError = true)), | ||
|
|
@@ -243,18 +243,18 @@ object VpnCheckRunner { | |
| needsReview = true, | ||
| findings = listOf(Finding(error.message ?: error::class.java.simpleName, isError = true)), | ||
| ) | ||
| fun indirect(context: Context, error: Throwable): CategoryResult = CategoryResult( | ||
| fun indirect(@Suppress("UNUSED_PARAMETER") context: Context, error: Throwable): CategoryResult = CategoryResult( | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. тоже самое |
||
| name = "Indirect", | ||
| detected = false, | ||
| needsReview = true, | ||
| findings = listOf(Finding(error.message ?: error::class.java.simpleName, isError = true)), | ||
| ) | ||
| fun location(context: Context, error: Throwable): CategoryResult = CategoryResult( | ||
| fun location(@Suppress("UNUSED_PARAMETER") context: Context, error: Throwable): CategoryResult = CategoryResult( | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. тоже самое |
||
| name = "Location", | ||
| detected = false, | ||
| findings = listOf(Finding(error.message ?: error::class.java.simpleName, isError = true)), | ||
| ) | ||
| fun native(context: Context, error: Throwable): CategoryResult = CategoryResult( | ||
| fun native(@Suppress("UNUSED_PARAMETER") context: Context, error: Throwable): CategoryResult = CategoryResult( | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. тоже самое |
||
| name = "Native", | ||
| detected = false, | ||
| findings = listOf(Finding(error.message ?: error::class.java.simpleName, isError = true)), | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -509,6 +509,7 @@ object UnderlyingNetworkProber { | |
| ) | ||
| } | ||
|
|
||
| @Suppress("DEPRECATION") | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. убрать/передать функцию вместо глушения ошибки |
||
| private fun buildProbeEnvironment(context: Context): ProbeEnvironment { | ||
| val cm = context.getSystemService(Context.CONNECTIVITY_SERVICE) as ConnectivityManager | ||
| val networks = cm.allNetworks.mapNotNull { network -> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| <vector xmlns:android="http://schemas.android.com/apk/res/android" | ||
| android:width="24dp" | ||
| android:height="24dp" | ||
| android:viewportWidth="24" | ||
| android:viewportHeight="24"> | ||
| <path | ||
| android:fillColor="#000000" | ||
| android:pathData="M9.78,18.65l0.28,-4.23l7.68,-6.92c0.34,-0.31 -0.07,-0.46 -0.52,-0.19L7.74,13.3L3.64,12c-0.88,-0.25 -0.89,-0.86 0.2,-1.3l15.97,-6.13c0.73,-0.33 1.43,0.18 1.15,1.3l-2.72,12.81c-0.19,0.91 -0.74,1.13 -1.5,0.71L12.6,16.3l-1.99,1.93C10.38,18.46 10.1,18.65 9.78,18.65Z"/> | ||
| </vector> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
он более не используется, убирать надо просто