Skip to content
This repository was archived by the owner on May 1, 2020. It is now read-only.

[MRG] Fix relative imports & improve package discovery#24

Open
mohamed-ali wants to merge 2 commits intoyahoo:masterfrom
mohamed-ali:fix-relative-imports
Open

[MRG] Fix relative imports & improve package discovery#24
mohamed-ali wants to merge 2 commits intoyahoo:masterfrom
mohamed-ali:fix-relative-imports

Conversation

@mohamed-ali
Copy link
Copy Markdown

Fixes #20.

As described in pep-0404:

In Python 3, implicit relative imports within packages are no longer available - only absolute imports and explicit relative imports are supported.

The solution to the recent import problems, that is compatible with both python2 and python3 is to use explicit relative import.

A more thorough discussion about this subject can be found here.

This PR:

  • Fixes the above import problem.
  • Improves package discovery.

@yahoocla
Copy link
Copy Markdown

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄

@mohamed-ali
Copy link
Copy Markdown
Author

CLA signed.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 88.443% when pulling 1f5834d on mohamed-ali:fix-relative-imports into 0f17655 on yahoo:master.

@mohamed-ali
Copy link
Copy Markdown
Author

mohamed-ali commented Apr 11, 2019

@pumpikano could you have a look at this PR, it fixes the import problem in python3 and is compatible with both python2 & 3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants