This repository was archived by the owner on May 1, 2020. It is now read-only.
[MRG] Fix relative imports & improve package discovery#24
Open
mohamed-ali wants to merge 2 commits intoyahoo:masterfrom
mohamed-ali:fix-relative-imports
Open
[MRG] Fix relative imports & improve package discovery#24mohamed-ali wants to merge 2 commits intoyahoo:masterfrom mohamed-ali:fix-relative-imports
mohamed-ali wants to merge 2 commits intoyahoo:masterfrom
mohamed-ali:fix-relative-imports
Conversation
|
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
Author
|
CLA signed. |
Author
|
@pumpikano could you have a look at this PR, it fixes the import problem in python3 and is compatible with both python2 & 3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20.
As described in pep-0404:
The solution to the recent import problems, that is compatible with both python2 and python3 is to use explicit relative import.
A more thorough discussion about this subject can be found here.
This PR: