This repository was archived by the owner on May 1, 2020. It is now read-only.
[MRG] Solve some pep8/flake8 issues & some code refactoring#25
Open
mohamed-ali wants to merge 10 commits intoyahoo:masterfrom
mohamed-ali:fix-some-flake8-issues
Open
[MRG] Solve some pep8/flake8 issues & some code refactoring#25mohamed-ali wants to merge 10 commits intoyahoo:masterfrom mohamed-ali:fix-some-flake8-issues
mohamed-ali wants to merge 10 commits intoyahoo:masterfrom
mohamed-ali:fix-some-flake8-issues
Conversation
Collaborator
|
Thanks a lot for this! It looks excellent. Actually I am no longer an admin of this repo since I no longer work at Yahoo, so I currently cannot do the merge. However, I am working out an arrangement so that I can continue to maintain this. I'll follow up here soon with an update and we can get this and your other PR merged. Thanks. |
Author
|
Hi @pumpikano, is there any progress on the status/maintainability of this library? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to improve the code quality by reducing the number of alerts thrown by flake8:
After the PR:
The fourth commit reduces further the number of flake8 issues:
With commit 5-> 7 the number of issues is further reduced:
Down to 57 with the commit 8:
The commits 9 and 10 finish fixing all identified flake8 issues:
PS:
lopq_model_pb2.pyis skipped because it's autogenerated by protobuf