Skip to content

Give nodes more time to create ephemeral nodes after zk failure #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
secwall merged 1 commit into from
Mar 19, 2026
Merged

Give nodes more time to create ephemeral nodes after zk failure #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/features/01_cluster_maintenance.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,22 +217,22 @@ Feature: Cluster mode maintenance tests
And valkey host "valkey1" should be master
And valkey host "valkey2" should be replica of "valkey1"
And valkey host "valkey3" should be replica of "valkey1"
And zookeeper node "/test/health/valkey1" should match json within "30" seconds
And zookeeper node "/test/health/valkey1" should match json within "90" seconds
"""
{
"ping_ok": true,
"is_master": true,
"is_read_only": false
}
"""
And zookeeper node "/test/health/valkey2" should match json within "30" seconds
And zookeeper node "/test/health/valkey2" should match json within "90" seconds
"""
{
"ping_ok": true,
"is_master": false
}
"""
And zookeeper node "/test/health/valkey3" should match json within "30" seconds
And zookeeper node "/test/health/valkey3" should match json within "90" seconds
"""
{
"ping_ok": true,
Expand Down
6 changes: 3 additions & 3 deletions tests/features/01_sentinel_maintenance.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,22 +248,22 @@ Feature: Sentinel mode maintenance tests
And valkey host "valkey1" should be master
And valkey host "valkey2" should be replica of "valkey1"
And valkey host "valkey3" should be replica of "valkey1"
And zookeeper node "/test/health/valkey1" should match json within "30" seconds
And zookeeper node "/test/health/valkey1" should match json within "90" seconds
"""
{
"ping_ok": true,
"is_master": true,
"is_read_only": false
}
"""
And zookeeper node "/test/health/valkey2" should match json within "30" seconds
And zookeeper node "/test/health/valkey2" should match json within "90" seconds
"""
{
"ping_ok": true,
"is_master": false
}
"""
And zookeeper node "/test/health/valkey3" should match json within "30" seconds
And zookeeper node "/test/health/valkey3" should match json within "90" seconds
"""
{
"ping_ok": true,
Expand Down
Loading