Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates installation/docs and share-link encoding to reflect current project structure and tooling requirements, and to improve share URL robustness.
Changes:
- Make
postinstall:ammonia-wasmconditional oncargoavailability. - Switch shared-state URL hash encoding to
b64EncodeUnicode(...)for Unicode-safe base64. - Refresh README: remove obsolete
web/folder reference, add prerequisites (Bun/Rust), expand supported pipeline list, and update Angular link toangular.dev.
Reviewed changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Adjusts postinstall behavior for building the Ammonia WASM package based on cargo availability. |
| app/pages/shared.vue | Updates share-state hash encoding to use the project’s Unicode-safe base64 helper. |
| README.md | Updates install instructions/prerequisites, supported pipeline list, and fixes outdated links/paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi inside a previous readme a folder
webwas used but not exist so i remove it .Ammoniainstallation but without cargo installed on user machine a crash occured.CustomandIframevieware used in project but not listed.