Skip to content

fix web typo and add requirement#6

Open
Tednoob17 wants to merge 3 commits intoyeswehack:mainfrom
Tednoob17:main
Open

fix web typo and add requirement#6
Tednoob17 wants to merge 3 commits intoyeswehack:mainfrom
Tednoob17:main

Conversation

@Tednoob17
Copy link
Contributor

Hi inside a previous readme a folder web was used but not exist so i remove it .

  • A project use a cargo during Ammonia installation but without cargo installed on user machine a crash occured.
  • A bun also need for installation so i add it in installation requirement part
  • Custom and Iframeview are used in project but not listed.
  • And I also update angular.io link who recently do a 302 return to angular.dev

Copilot AI review requested due to automatic review settings March 10, 2026 11:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates installation/docs and share-link encoding to reflect current project structure and tooling requirements, and to improve share URL robustness.

Changes:

  • Make postinstall:ammonia-wasm conditional on cargo availability.
  • Switch shared-state URL hash encoding to b64EncodeUnicode(...) for Unicode-safe base64.
  • Refresh README: remove obsolete web/ folder reference, add prerequisites (Bun/Rust), expand supported pipeline list, and update Angular link to angular.dev.

Reviewed changes

Copilot reviewed 4 out of 7 changed files in this pull request and generated 2 comments.

File Description
package.json Adjusts postinstall behavior for building the Ammonia WASM package based on cargo availability.
app/pages/shared.vue Updates share-state hash encoding to use the project’s Unicode-safe base64 helper.
README.md Updates install instructions/prerequisites, supported pipeline list, and fixes outdated links/paths.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants