Open
Conversation
allow messages to be intercepted
typedef for messagePreProcess
iterate sub version
improved default, pass whole event
rebuilt tsc files
Author
|
I don't like maintaining code separately so I instead hacked this by overwriting the onmessage with the following: It isn't as clean a solution as it required me to rewrite the non-exported |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't tried my hand at writing JSDoc before so please confirm I didn't do something boneheaded here
My problem statement is that my server (API Gateway) wont allow me to transmit my data in binary, so I had to base64 encode it which means that I need to tell y-quill to convert that data to unit8array/buffer -- I think it'd be helpful to future proof by allowing the user to provide a function that pre-processes their websocket events; with the default/fallback behavior of your typical processing (reading into a unit8array)
Huly®: YJS-730