Chore: Public api does automatically fill in all arguments with typehints #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalisp
approved these changes
Nov 22, 2024
Member
kalisp
left a comment
kalisp
left a comment
There was a problem hiding this comment.
Type hints shown, nothing breaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Modified automated api script to fill in all arguments with same defaults as are used in
ServerAPIto_api.pyfunctions.Additional review information
Also added typehints logic, but that is not 100%, should not break the code if "fails" to resolve the typehint correctly.
Testing notes:
ayon_apidoes not cause any issues and works as before.