Skip to content

Mark lithops tests as flaky, run in separate CI job#934

Merged
TomNicholas merged 18 commits intozarr-developers:mainfrom
TomNicholas:mark-lithops-tests-flaky
Mar 16, 2026
Merged

Mark lithops tests as flaky, run in separate CI job#934
TomNicholas merged 18 commits intozarr-developers:mainfrom
TomNicholas:mark-lithops-tests-flaky

Conversation

@TomNicholas
Copy link
Member

@TomNicholas TomNicholas commented Mar 16, 2026

Summary

  • Mark lithops tests with @pytest.mark.flaky so they're skipped by default in the main test matrix (as suggested in Test python 3.12, 3.13 #932 (comment))
  • Add --run-flaky pytest option (matching xarray's approach)
  • Add a separate flaky-tests CI job with continue-on-error: true
  • Add run-flaky-tests pixi task

The lithops tests intermittently fail with ImportError: cannot import name 'VirtualiZarrDatasetAccessor' due to lithops' module shipping mechanism producing incomplete copies of virtualizarr in subprocess workers. Analysis posted at #929 (comment).

Test plan

  • Verify lithops tests are skipped in normal CI runs
  • Verify flaky-tests job runs and is allowed to fail

🤖 Generated with Claude Code

TomNicholas and others added 18 commits October 24, 2025 09:34
Lithops tests intermittently fail with an ImportError due to lithops'
module shipping mechanism producing incomplete copies of virtualizarr
in subprocess workers. See https://github.com/zarr-developers/VirtualiZarr/issues/XXX

- Add --run-flaky pytest option (matching xarray's approach)
- Mark lithops tests with @pytest.mark.flaky so they're skipped by default
- Add a separate flaky-tests CI job with continue-on-error: true

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.23%. Comparing base (34d3ecc) to head (fc975a8).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #934      +/-   ##
==========================================
+ Coverage   89.13%   89.23%   +0.09%     
==========================================
  Files          33       33              
  Lines        2025     2025              
==========================================
+ Hits         1805     1807       +2     
+ Misses        220      218       -2     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@chuckwondo chuckwondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@TomNicholas TomNicholas merged commit bdc1a3a into zarr-developers:main Mar 16, 2026
18 checks passed
@TomNicholas TomNicholas deleted the mark-lithops-tests-flaky branch March 16, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants