Grind main/menu_compa: 95.749% -> 95.864% (cast-faithfulness)#17664
Merged
Conversation
…rlwi byte-mask) Line 295 SetColor passed the alpha as static_cast<signed char>, but the target emits a clrlwi r7,r0,24 (unsigned-byte zero-extend) before the CColor(Uc,Uc,Uc,Uc) constructor call (Ghidra 80160edc row ~571, __ct__6CColorFUcUcUcUc 4th arg). The sibling SetColor at line 341 already uses static_cast<unsigned char>; making line 295 consistent matches the byte-mask the original emitted. CompaDraw misalign 23 -> 21; unit fuzzy 95.749 -> 95.864. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CompaDraw line 295
SetColorpassed the alpha asstatic_cast<signed char>, but the target binary emits aclrlwi r7, r0, 24(unsigned-byte zero-extend) before theCColor(Uc,Uc,Uc,Uc)constructor call. Changing it tostatic_cast<unsigned char>reproduces that byte-mask.Faithfulness: Ghidra ground truth (resources/ghidra-decomp-1-31-2026/80160edc_CompaDraw__8CMenuPcsFv.c) passes the alpha to
__ct__6CColorFUcUcUcUc(4 unsigned-char params), and the siblingSetColorat line 341 already usesstatic_cast<unsigned char>. This makes the two consistent.Gate
🤖 Generated with Claude Code