Grind main/menu_item: 97.234% -> 97.350% (cast/schedule named-temp)#17666
Merged
Conversation
Factor (float)(1.0/duration) into a named local widthFrac before the multiply by (float)entry->w, mirroring Ghidra ItemInit/ItemDraw ground truth (80159df4_ItemDraw line 134-135): in_f29 = (float)(DOUBLE_80332e68 / (local_b0 - DOUBLE_80332ea0)) * (float)(local_b8 - DOUBLE_80332ea0). The named temp forces the division/frsp to be materialized before the w-bias subtract, matching the target schedule. ItemDraw misalign 9 -> 7; unit fuzzy 97.234 -> 97.350. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ItemDraw: factor
(float)(1.0/duration)into a named localwidthFracbefore multiplying by(float)entry->w.This mirrors the Ghidra ground truth (
80159df4_ItemDraw__8CMenuPcsFv.clines 134-135):The named temp forces the division/
frspto be materialized before the w-biasfsubs, matching the target instruction schedule. Value-identical, behavior-safe.Gate
frsp/fsubsorder)main/menu_itemfuzzy_match_percent 97.234 -> 97.350🤖 Generated with Claude Code