Stability Fixes, Performance Optimizations, and v1.0.5 Release#8
Open
intelliDean wants to merge 133 commits intozecdev:mainfrom
Open
Stability Fixes, Performance Optimizations, and v1.0.5 Release#8intelliDean wants to merge 133 commits intozecdev:mainfrom
intelliDean wants to merge 133 commits intozecdev:mainfrom
Conversation
Implements Milestone 3 deliverables on top of the existing M1/M2 foundation: ## GitHub Actions CI - e2e-test.yml: Full devnet startup, smoke tests, artifact upload on failure - smoke-test.yml: Lightweight health checks on every push - Job timeout set to 120 minutes to accommodate Docker build time ## Two-Node Zebra Regtest Cluster - zebra-miner: internal miner, mines blocks continuously - zebra-sync: second node for cluster readiness verification - Fixed zebra-sync.toml config fields for Zebra 4.1.0 compatibility (initial_testnet_peers, crawl_new_peer_interval) - All indexer/faucet services point to zebra-miner for reliable data ## CLI Enhancements (zeckit up / test) - health.rs: detailed RPC error messages surfaced during wait loops - up.rs: periodic error reporting during Zebra startup - test.rs: 7-test smoke suite; cluster sync is warn-only (Regtest P2P peering is best-effort in isolated CI environments) ## Docker / Entrypoint - entrypoint.sh: verbose startup logging, config validation, zebrad --version - Sync node waits for miner to be reachable before starting zebrad - Removed container_name fields to prevent naming conflicts in CI - Relaxed port bindings to 0.0.0.0 for CI compatibility ## E2E Golden Flow (verified in CI) fund (650 ZEC coinbase) -> shield (transparent->Orchard) -> shielded send (0.05 ZEC) TXID confirmed on-chain, faucet live with 650+ ZEC Orchard balance ## README - CI badges (E2E Tests, Smoke Test, License) - M3 complete status with deliverable list - Updated test suite table (7 tests with WARN explanation) - M4 roadmap entry
…e instead of skipping
…insufficient funds
…t-test verification
…m timeout, fix embedded zebra-sync peers
Previously, the --timeout flag was applied independently to each service (Miner, Sync, Backend, Faucet) in sequence. In the worst case, a 1-minute timeout could compound into 4+ minutes of actual wait time, making the CI startup_timeout_minutes parameter unreliable. This refactor introduces a single shared deadline computed once at the start of Step 3: let deadline = Instant::now() + Duration::from_secs(timeout * 60); Every wait-loop now checks Instant::now() >= deadline against this shared clock. When the global budget expires anywhere in the startup sequence, the process immediately fails with a clear error message indicating the global timeout was exceeded. The sync-parity soft-fail retains its 30-second local budget but now also respects the global deadline, so it can no longer silently consume time that allows startup to escape the requested timeout. Progress percentages for Backend and Faucet now reflect the remaining global budget rather than a fresh per-stage clock. Fixes: Failure Drill 'startup-timeout' drill incorrectly reporting 'pass' because the devnet became healthy after the injected 1-minute window due to compound per-service timeouts.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fulfils the requirements for Milestone 3 by converting ZecKit into a fully reusable GitHub Action. It enables any external repository to effortlessly spin up a Zcash devnet and execute the E2E Golden Flow (Fund → Shield → Send → Verify) against both zaino and lightwalletd backends.
Key Improvements:
1. Stability Fixes (Zebra 4.3.0 Support)
initial_regtest_peersconfiguration field.zeckit upexperience.2. Performance Optimisations (GitHub ARM64 Runners)
build-imagesworkflow to use native GitHub-hosted ARM64 runners (ubuntu-24.04-arm) instead of slow QEMU emulation.3. Versioning and Workspace Cleanup
main,m3-implementation, andnu6-upgrade.This PR establishes a robust, high-performance baseline for all future ZecKit development.