Feat/worldmirror2 integration#6
Merged
Merged
Conversation
- plugin.gd: rename SplatGenerator→SplatGen autoload (conflict with global class_name SplatGenerator) - hybrid_renderer.gd:147-155: fix scope — splat variable declarations were outside the for j loop after previous indentation fix. Restored proper nesting inside the splat generation loop. - gaussian_splat.gd: add BrushType enum (STONE/SPONGE/GAUSSIAN) + brush_type field, LIQUID variant to LayerType enum - colmap_sparse_importer.gd:172: -img.rotation.inverse() → -(img.rotation.inverse()) (parenthesize unary minus on quaternion for Godot 4.6) - multi_source_processor.gd: DirAccess.remove_recursive() → remove_absolute() (Godot 4 API, static method replaces removed recursive variant) - pre_reconstruction_validator.gd: Regex→RegEx (Godot 4 class name) x4, remove_recursive→remove_absolute x2
- splat_renderer.gd:217-218: Vector3.INF → Vector3(INF,INF,INF) / -Vector3.INF → Vector3(-INF,-INF,-INF) - enhanced_point_cloud.gd:168-169: same fix - splat_sorter.gd:251: same fix - Resolves 5/5 remaining Godot 4.6 deprecation warnings
- plugin.gd: rename StyleEngine→StyleEng autoload (conflict with class_name). Remove SplatGen autoload entirely (SplatGenerator extends RefCounted, autoloads must inherit Node. Utility class accessed via static methods). - hybrid_renderer.gd:144-155: fix scope — splat creation block was outside the for j loop after previous indentation fix. Restored proper nesting with extra indent level inside the loop where pos/normal are defined. - colmap_sparse_importer.gd:172: avoid Basis unary minus by computing -R^T * t as -(R^T * t) where R^T*t is Vector3 (negate vector, not basis).
- project.godot: deleted SplatGen autoload (RefCounted, not a Node). The plugin.gd already removed it, but Godot persists entries in project.godot. Manual cleanup needed on next editor restart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.