Feat/worldmirror2 integration#8
Merged
Merged
Conversation
…rame - studio_dependency_checker.gd: remove open_console=true from ALL OS.execute() calls (was opening terminal windows on every check). Add results cache for _check_worldmirror2_available() to avoid repeated slow Python import checks during session setup. read_stderr=false for speed. - studio_processor.gd: replace synchronous OS.execute() in get_preview_frame() with OS.create_process() + async while loop (await get_tree().process_frame). Prevents FFmpeg hang from freezing Godot main thread. - studio_to_3d_panel.gd:231: add missing 'await' on get_preview_frame() call in _on_roi_pressed() (other call sites already had await). Fixes user-reported freeze when loading video in Studio panel.
- studio_dependency_checker.gd: is_worldmirror2_ready() → static method with static var _wm2_cache. Previous cache was instance-level and defeated by StudioDependencyChecker.new() creating fresh instances on every _update_wm2_status() call. Now truly caches the first Python import check result for the entire editor session. - studio_to_3d_panel.gd: _update_wm2_status() uses static method directly, no more node instantiation per check.
- Rewrite studio_dependency_checker.gd: fix tab/space mismatch (was mixing spaces in get_diagnostic_text), restore accidentally deleted check_all_tools() and _is_command_available() methods. All indentation now uses tabs. - Remove StyleEng autoload from plugin.gd and project.godot — StyleEngine extends RefCounted, autoloads must extend Node. Utility class accessed via static methods and class_name, no singleton needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.