-
Notifications
You must be signed in to change notification settings - Fork 8.4k
refactor mcux sar adc driver #100978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ZhaoxiangJin
wants to merge
5
commits into
zephyrproject-rtos:main
Choose a base branch
from
nxp-upstream:rewrite-sar-adc-driver
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor mcux sar adc driver #100978
ZhaoxiangJin
wants to merge
5
commits into
zephyrproject-rtos:main
from
nxp-upstream:rewrite-sar-adc-driver
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
850d1c3 to
a469029
Compare
a469029 to
c908ef4
Compare
cc215e1 to
c10c8e8
Compare
Zephyr's current ADC API only supports 32 logical channels, which is inadequate for SAR ADCs on certain SoCs. For instance, the ADC on the MCXE31B has 64 hardware channels. The previous implementation used a one-to-one mapping between logical and hardware channels. In the new SAR ADC driver version, we bind hardware channels to logical channels via the zephyr,input-positive property, enabling us to access any channel. Currently, only imx93 uses this ADC. To maintain the bisectability of Zephyr commits, in this commit we will also modify the imx93-related files. Now the sar adc is native driver, so, remove CONFIG_MCUX_COMPONENT_driver.sar_adc from the glue cmake. Signed-off-by: Zhaoxiang Jin <Zhaoxiang.Jin_1@nxp.com>
enable ADC clock control Signed-off-by: Zhaoxiang Jin <Zhaoxiang.Jin_1@nxp.com>
Enable SAR ADC support for frdm_mcxe31b. Signed-off-by: Zhaoxiang Jin <Zhaoxiang.Jin_1@nxp.com>
Enable adc_sequence and adc_dt samples on frdm_mcxe31b board Signed-off-by: Zhaoxiang Jin <Zhaoxiang.Jin_1@nxp.com>
Add migration guide documentation for NXP SAR ADC driver. Signed-off-by: Zhaoxiang Jin <Zhaoxiang.Jin_1@nxp.com>
c10c8e8 to
be0bd7b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: ADC
Analog-to-Digital Converter (ADC)
area: Boards/SoCs
area: Clock Control
area: Devicetree Bindings
area: Samples
Samples
area: Tests
Issues related to a particular existing or missing test
platform: NXP MCU
platform: NXP
NXP
Release Notes
To be mentioned in the release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



zephyr,input-positiveproperty, enabling us to access any channel. Currently, only imx93 uses this ADC. To maintain the bisectability of Zephyr commits, the refactored code and imx93-related file updates are placed in the same commit. The migration-guide-4.4.rst has also been updated accordingly to document this change.Logs