fix: index html-only Gmail message bodies#2
Open
RitwijParmar wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
text/plainto cleanedtext/htmltext/plainas the preferred source when multipart alternatives include both formatsurlparseimport so the touched file passes RuffWhy
Zemail's README positions the tool as full-inbox semantic search, but many real Gmail messages are HTML-only. Before this change,
_decode_body()returned an empty string for those messages, so indexing fell back to snippets rather than the actual email body. That makes retrieval/reranking weaker exactly on the long-tail emails where semantic search should help most.The fallback is intentionally dependency-free: it strips script/style content, preserves block boundaries as newlines, unescapes entities, and normalizes whitespace before the body is embedded.
Validation
.venv/bin/python -m pytest tests/test_gmail_client.py -q-> 3 passed.venv/bin/python -m ruff check zemail/gmail_client.py tests/test_gmail_client.py.venv/bin/python -m compileall -q zemail testsgit diff --check