WIP: Argparse reaction reference#159
Open
jonls wants to merge 2 commits intozhanglab:developfrom
Open
Conversation
The actual reaction ID can only be obtained from the resulting object by resolving against a MetabolicModel object. If the reaction does not exist in the MetabolicModel, an error is raised.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add specialized
argparsetype for reaction references. This type guards against using non-existing ID since the actual ID string can only be obtained (throughresolve()) if the reaction is defined in the model. Currently requires aMetabolicModelwhich is not ideal for commands that otherwise don't require this model representation. This may have to wait for the work on restructuringNativeModelto be implemented in terms of that model representation instead.