Skip to content

Show error in Actions summary for safety issues in normal/scheduled runs #2138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andy-maier merged 1 commit into from
May 9, 2026
Merged

Show error in Actions summary for safety issues in normal/scheduled runs #2138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,8 +443,21 @@ pylint: $(done_dir)/pylint_$(pymn)_$(PACKAGE_LEVEL).done

.PHONY: safety
safety: Makefile $(done_dir)/develop_$(pymn)_$(PACKAGE_LEVEL).done $(safety_develop_policy_file) $(safety_install_policy_file) minimum-constraints-develop.txt minimum-constraints-install.txt
safety check --policy-file $(safety_develop_policy_file) -r minimum-constraints-develop.txt --full-report || test '$(RUN_TYPE)' == 'normal' || test '$(RUN_TYPE)' == 'scheduled' || exit 1
safety check --policy-file $(safety_install_policy_file) -r minimum-constraints-install.txt --full-report || test '$(RUN_TYPE)' == 'normal' || exit 1
safety check --policy-file $(safety_develop_policy_file) -r minimum-constraints-develop.txt --full-report; \
rc_dev=$$?; \
safety check --policy-file $(safety_install_policy_file) -r minimum-constraints-install.txt --full-report; \
rc_ins=$$?; \
where=""; \
if [[ $${rc_dev} -ne 0 ]]; then where="development"; fi; \
if [[ $${rc_ins} -ne 0 ]]; then where="$${where:+$$where,}install"; fi; \
if [[ -n $${where} ]]; then \
if [[ "$(RUN_TYPE)" == "release" || "$(RUN_TYPE)" == "local" ]]; then \
echo "Safety issues found in $${where}"; \
exit 1; \
else \
echo "::error::Safety issues found in $${where} - They need to be fixed before the next release"; \
fi; \
fi
@echo "Makefile: $@ done."

.PHONY: bandit
Expand Down
6 changes: 6 additions & 0 deletions changes/noissue.33.feature.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Dev: Safety issues that are detected in normal and scheduled Actions runs
now cause an error to be shown in the Actions summary. They still
(intentionally) do not cause the Actions run to fail. Note that safety issues
detected during an Actions release run, or during local use, do cause the
make command and Actions run to fail. In addition, the safety command is now
always run for both development and install before checking for failure.
Loading