In Makefile on Windows: Used bash and cleaned up Windows-specific commands#2139
Merged
Conversation
andy-maier
force-pushed
the
andy/cleanup-makefile-windows
branch
2 times, most recently
from
8823b88 to
3ae2b7a
Compare
Collaborator
|
coverage: 77.19%. remained the same — andy/cleanup-makefile-windows into master |
…mands Details: * Dev: Using bash as the make shell on Windows. This allows cleaning up all the conditional processing for Windows-specific commands and the use of "bash -c". Signed-off-by: Andreas Maier <maiera@de.ibm.com>
andy-maier
force-pushed
the
andy/cleanup-makefile-windows
branch
from
3ae2b7a to
d18923b
Compare
andy-maier
changed the title
Member
Author
|
Since Chaithra approved PR #2138 which at the time of approval contained this PR, I am considering this PR approved as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For details, see the commit message.
Needs to be applied to all projects.
Should be rolled back to stable version to avoid future merge conflicts.