-
Notifications
You must be signed in to change notification settings - Fork 61
Ignore color_temperature attribute when computing light capabilities
#572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #572 +/- ##
=======================================
Coverage 97.02% 97.02%
=======================================
Files 63 63
Lines 10535 10535
=======================================
Hits 10222 10222
Misses 313 313 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TheJulianJES
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the original GLEDOPTO GL-C-009P issue, there's an old quirk that just removes the color cluster. If that were changed to a v2 quirk, it would also fix the issue.
But I agree this is the more proper fix. Going through the affected devices, the only devices we may wanna have a look at are:
- LEDVANCE RGB light, as it seems to support color temperature in Z2M:
zigbee-herdsman-converters/src/devices/sylvania.ts#L155-L159
(no idea why the range is "undefined", but this seems to apply to other "tunable white" devices as well: zigbee-herdsman-converters/src/devices/ledvance.ts#L21-L25) - the Tuya light
_TZ3210_bfwvfyx1, but it apparently has lackluster support in ZHA, yet at least allows controlling the color temperature range somehow
There may be other we are missing, but I think this change should be fine (for the next major release). Only "important issue" may be this (and other?) LEDVANCE lights..
|
Is there any testing that needs to be done with this change? If so I am willing to apply any file changes for the issue I reported until it's put into a future release. |
|
@GTerplan Give it a try, it should resolve your issue. We've identified that making this change will cause other devices to break so we're working on fixing those first. |
|
light.ikea_of_sweden_tradfri_bulb_gu10_ws_345lm and |
@puddly Since I am using the HA OS VM I wasn't able to apply any of your changes, but I did create a zha_quirks folder within the config folder and had to modify the glc009p.py file based on my device signature. I have included the updated file here since I am hoping that can just be updated in the main zha quirks folder during an update which should not break anything. |
See home-assistant/core#156133.
The device switches modes. Color temperature is the only mode where we peek at attribute values to determine capabilities (all others just use the
color_capabilitiesbitmap). The number of affected devices according to diagnostics is very small and all of the changes look reasonable to me.