-
Notifications
You must be signed in to change notification settings - Fork 61
Add event platform for client cluster #594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Just noticed that #419 exists too. I think this is simpler and stands on the main standardized clusters. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #594 +/- ##
==========================================
+ Coverage 97.29% 97.32% +0.02%
==========================================
Files 62 63 +1
Lines 10712 10790 +78
==========================================
+ Hits 10422 10501 +79
+ Misses 290 289 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Btw. I've explicitly avoided some fixed structure here. Tried to keep the original cluster commands as is. Currently HA has very few devices classes for events, so the structure of the event data there has not given correct structure. Given the above situation, inventing some in-between structure that isn't 1 to 1 mapped to zigbee spec seem pointless and only adds complexity. |
bfdb1b8 to
4605fb6
Compare
- Add event entities for LevelControl client clusters
|
So rebased on the new cluster rework. Must say it looks much cleaner and less complicated. |
Depends on home-assistant/core#157853 for support in HA