Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 28, 2026

  • Update minimum zigpy version from 0.78.0 to 0.91.2 in pyproject.toml
  • Migrate enum_factory imports to use enum40, enum24, enum64 directly from zigpy.types in zigpy_znp/types/basic.py
  • Run test suite to verify all tests pass (389 tests passed)
  • Verified enum serialization/deserialization works correctly
  • Fix pre-commit configuration issues
    • Update flake8/pflake8 to version 7.0.0 for Python 3.12 compatibility
    • Fix flake8 C419 warnings (unnecessary list comprehensions in tests)
    • Update mypy to v1.19.1 and zigpy>=0.91.2 dependency
    • Fix all mypy type errors properly (no suppression of real issues)
      • Fixed write_devices return type annotation to None
      • Fixed method signatures for zigpy 0.91.2 API compatibility
      • Added property setters where needed
      • Fixed LVList type parameters: LVList[uint16_t, uint8_t] not LVList[uint8_t, uint16_t]
      • Fixed type annotations for better compatibility
  • Run pre-commit run --all-files successfully - ALL CHECKS PASS!
Original prompt

Bump the minimum zigpy version to 0.91.2 and migrate enum_factory to the correct enum* type from zigpy. I believe it is enum40. Run pre-commit checks and the test suite to ensure all tests pass. Some tests may be flaky so run once or twice to get them to pass.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: puddly <32534428+puddly@users.noreply.github.com>
Copilot AI changed the title [WIP] Bump minimum zigpy version to 0.91.2 and migrate enum_factory Bump zigpy to 0.91.2 and migrate from enum_factory to direct enum imports Jan 28, 2026
Copilot AI requested a review from puddly January 28, 2026 21:28
@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.46%. Comparing base (012067a) to head (8ab32b4).
⚠️ Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
zigpy_znp/zigbee/device.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #268      +/-   ##
==========================================
- Coverage   98.52%   98.46%   -0.06%     
==========================================
  Files          43       43              
  Lines        3586     3588       +2     
==========================================
  Hits         3533     3533              
- Misses         53       55       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI and others added 5 commits January 28, 2026 21:38
Co-authored-by: puddly <32534428+puddly@users.noreply.github.com>
Co-authored-by: puddly <32534428+puddly@users.noreply.github.com>
Co-authored-by: puddly <32534428+puddly@users.noreply.github.com>
Co-authored-by: puddly <32534428+puddly@users.noreply.github.com>
Co-authored-by: puddly <32534428+puddly@users.noreply.github.com>
Copilot AI changed the title Bump zigpy to 0.91.2 and migrate from enum_factory to direct enum imports Bump zigpy to 0.91.2 and migrate from enum_factory to native enum types Jan 28, 2026
@puddly puddly marked this pull request as ready for review January 29, 2026 21:16
@puddly
Copy link
Collaborator

puddly commented Jan 29, 2026

@copilot The zigpy_t.LVList changes are incorrect. zigpy_t.LVList[t.uint16_t] is zigpy_t.LVList[t.uint16_t, t.uint8_t], not zigpy_t.LVList[t.uint8_t, t.uint16_t].

Co-authored-by: puddly <32534428+puddly@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 29, 2026

@copilot The zigpy_t.LVList changes are incorrect. zigpy_t.LVList[t.uint16_t] is zigpy_t.LVList[t.uint16_t, t.uint8_t], not zigpy_t.LVList[t.uint8_t, t.uint16_t].

Fixed in commit 8ab32b4. Changed from LVList[uint8_t, uint16_t] to LVList[uint16_t, uint8_t] (item_type first, length_type second).

@puddly puddly merged commit ed9a268 into dev Jan 29, 2026
20 of 22 checks passed
Copilot stopped work on behalf of puddly due to an error January 29, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants