Align kubernetes python client#331
Conversation
| "kfp-pipeline-spec>=0.1.13,<0.2.0", | ||
| "kfp-server-api>=1.1.2,<2.0.0", | ||
| "kubernetes>=32", | ||
| "kubernetes>=30.1", |
There was a problem hiding this comment.
The MR summary talks about the following which is relevant for this MR. Please ensure only relevant information is added in the MRs 😄
This MR widens supported Python through 3.12
regenerates poetry.lock with Poetry 1.8.2,
and fixes GitLab CI by declaring a test stage so pipeline validation (including security-testing-variable-setup) succeeds.
``
There was a problem hiding this comment.
Yeah 😄
This description is copied from the py-zacs MR, missed to refactor it.
There was a problem hiding this comment.
No worries. Please update the MR description as per the latest conversation on this MR. Please continue to keep the descriptions of other MRs consistent with the updates to those MRs 😄
There was a problem hiding this comment.
Yes, updated MR description
| "kfp-pipeline-spec>=0.1.13,<0.2.0", | ||
| "kfp-server-api>=1.1.2,<2.0.0", | ||
| "kubernetes>=32", | ||
| "kubernetes>=30.1", |
There was a problem hiding this comment.
Once you update the version range, this zillow-metaflow change needs to be confirmed with another repository, before we can merge it.
You can temporarily set the dev version in aip-toleration-integration-test, rebuild its lock file, confirm the gitlab pipeline is successful and paste it here for validation. After the merge, you can update that MR (and the other MRs) with the actual release version.
There was a problem hiding this comment.
Few repositories are built and tested with zillow-metaflow's dev version and those are listed in green highlight in spreadsheet.
Tested build in gitlab pipeline with feature branch version of metaflow in aip-toleration-integration-test pipeline.
There was a problem hiding this comment.
Thanks for the sheet. The challenge is there's too much data, i.e. the information of unrelated repositories, in it which can be overwhelming 😅
Also, it's essential to link the corresponding details in the MR like this, so that when we refer to this code change in github, we can directly go to the corresponding tests.
Finally, after updating in github, the corresponding mirror in gitlab runs a pipeline which will test the change like this. It's useful to link that also, just to make it easy for the reviewers to verify 😃
There was a problem hiding this comment.
Yes, you are correct about the mirrored repository. The v33 of k8s client looks good. Please use the corresponding zillow-metaflow dev version in the toleration integration test and confirm that the train-and-evaluate:review step in the corresponding gitlab pipeline passed (like this) - that's the step which actually uses zillow-metaflow.
Once verified please add the run in the MR description.
There was a problem hiding this comment.
Tested aip-toleration-integration-test pipeline run to test zillow-metaflow’s feature branch version.
- build job run - Built successfully with metaflow feature branch version.
- train-and-evaluate:review job run - Ran successfully
Also added this pipeline run in MR description
2 participants
Summary
This MR updates Kubernetes Python Client version to align it with Kubernetes server
Motivation
build,test-e2e, andpublish.AIP-9514: Align dependency constraints with current Python and Kubernetes client expectations.
CI was failing because jobs targeting stage: test ran against a pipeline that only defined build, test-e2e, and publish.
Risk / rollout notes
Pinning kubernetes to 33.1.0 is a major jump from the previous upper bound; consumers should confirm runtime behavior against their clusters and any code that uses the client’s APIs.
Testing
Consumers of zillow-metaflow are listed in spreadsheet
Below repositories are tested with dev/test version (2.3.3616.dev3616) of zillow-metaflow :
Refer to Kubernetes Python Client Release.