offline mode by wel97459 · Pull Request #440 · zjs81/meshcore-open

wel97459 · 2026-05-10T23:08:14Z

This lets you see the map, view contact messages, and channel messages from the last connected companion.

Copilot

Pull request overview

This PR introduces an “offline mode” experience by keeping the app usable when the companion connection is unavailable, and by restoring cached data scoped to the last connected companion.

Changes:

Remove auto-navigation-to-scanner-on-disconnect and instead allow browsing offline data in Contacts/Channels/Map.
Add a “Connect” action in overflow menus (when disconnected) and hide/guard message composers when offline.
Persist/restore last companion scope and preload cached companion-scoped data on startup; add new localization for the offline/companion-required dialog.

Reviewed changes

Copilot reviewed 46 out of 46 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
lib/utils/disconnect_navigation_mixin.dart	Removed mixin that forced navigation away on disconnect to enable offline browsing.
lib/screens/map_screen.dart	Adds Connect/Disconnect menu behavior based on connection state.
lib/screens/contacts_screen.dart	Removes forced disconnect navigation; adds Connect menu entry; blocks repeater/room logins while offline with a dialog.
lib/screens/chat_screen.dart	Hides input bar and prevents sending when disconnected.
lib/screens/channels_screen.dart	Removes forced disconnect navigation; adds Connect menu entry.
lib/screens/channel_chat_screen.dart	Hides composer and prevents sending when disconnected.
lib/models/path_history.dart	Adds `byteCount` field to `PathRecord`.
lib/main.dart	Initializes PrefsManager; restores last companion scope and loads cached data at startup; changes home screen to Contacts.
lib/connector/meshcore_connector.dart	Adds last-companion scoping persistence/restore and cached-data loading helpers; tweaks cached channel loading and lazy DM loading.
lib/l10n/app_*.arb	Adds `contact_connectCompanion` translation strings across locales.
lib/l10n/app_localizations*.dart	Adds generated localization getter for `contact_connectCompanion`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

zjs81 · 2026-05-11T04:09:59Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8ec82f87fe

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot

Pull request overview

Copilot reviewed 46 out of 46 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 46 out of 46 changed files in this pull request and generated 4 comments.

- Added functionality to load and restore the last companion's scope on app startup. - Implemented caching mechanisms for contacts, channels, and messages related to the current companion. - Updated UI to reflect connection status, including disabling message input when disconnected. - Introduced new dialog prompts to inform users when they need to connect to a companion for accessing features. - Refactored navigation logic to improve user experience when disconnected, directing users to the scanner screen. - Added localization strings for new companion connection prompts in multiple languages.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

…CoreConnector

…ness

- Introduced new dialog messages for connecting to a companion and handling disconnection across multiple languages. - Updated localization files for French, Hungarian, Italian, Japanese, Korean, Bulgarian, German, English, Spanish, Dutch, Polish, Portuguese, Russian, Slovak, Slovenian, Swedish, Ukrainian, and Chinese. - Modified the contacts and map screens to utilize the new dialog messages. - Enhanced the disconnect confirmation dialog to show a message upon successful disconnection. - Updated app bar to conditionally display radio stats based on companion connection status.

…d USB flow tests

Copilot

Pull request overview

Copilot reviewed 51 out of 51 changed files in this pull request and generated 8 comments.

+                  PopupMenuItem(
+                    child: Row(
+                      children: [
+                        const Icon(Icons.connect_without_contact),
+                        const SizedBox(width: 8),
+                        Text(context.l10n.contacts_zeroHopAdvert),
+                      ],
+                    ),
+                    onTap: () => {
+                      connector.sendSelfAdvert(flood: false),
+                      showDismissibleSnackBar(
+                        context,
+                        content: Text(context.l10n.settings_advertisementSent),
+                      ),
+                    },
                  ),
-                  onTap: () => {
-                    connector.sendSelfAdvert(flood: false),
-                    showDismissibleSnackBar(
-                      context,
-                      content: Text(context.l10n.settings_advertisementSent),
+                  PopupMenuItem(
+                    child: Row(
+                      children: [
+                        const Icon(Icons.cell_tower),
+                        const SizedBox(width: 8),
+                        Text(context.l10n.contacts_floodAdvert),
+                      ],
                    ),
-                  },
-                ),
-                PopupMenuItem(
-                  child: Row(
-                    children: [
-                      const Icon(Icons.cell_tower),
-                      const SizedBox(width: 8),
-                      Text(context.l10n.contacts_floodAdvert),
-                    ],
+                    onTap: () => {
+                      connector.sendSelfAdvert(flood: true),
+                      showDismissibleSnackBar(
+                        context,
+                        content: Text(context.l10n.settings_advertisementSent),
+                      ),
+                    },


  "dialog_disconnectConfirm": "Are you sure you want to disconnect from this device?",
+  "dialog_disconnectedTitle": "Disconnected",
+  "dialog_disconnectedMessage": "You have been disconnected from your companion.",
+  "dialog_connectCompanion": "Connect to a companion to access repeater and room server features.",


+  "dialog_connectCompanion": "Povežite se s spremljevalnikom za dostop do funkcij ponavljalnika in strežnika sob.",
+  "dialog_disconnectedTitle": "Prekinjeno",
+  "dialog_disconnectedMessage": "Prekinjena povezava s vašim spre伴ovalcem.",
+  "contact_connectCompanion": "Povežite se s ponсоbnikom za dostop do funkcij pon 반복nika in strežnika prostorov."


      successCount: json['success_count'] as int? ?? 0,
      failureCount: json['failure_count'] as int? ?? 0,
      routeWeight: (json['route_weight'] as num?)?.toDouble() ?? 1.0,
+      byteCount: json['byte_count'] as int? ?? 0,
    );


Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

…kHex

Copilot

Pull request overview

Copilot reviewed 51 out of 51 changed files in this pull request and generated 6 comments.

        // Only add non-empty channels
-        if (!channel.isEmpty) {
+        if (!channel.isEmpty &&
+            _channels.any((c) => c.pskHex != channel.pskHex)) {
          _channels.add(channel);


+    if (lastCompanionPublicKeyHex == null ||
+        lastCompanionPublicKeyHex.trim().isEmpty) {
+      return;
+    }
+    _selfPublicKey = hexToPubKey(lastCompanionPublicKeyHex);
+    _setScopedStorePublicKey(lastCompanionPublicKeyHex);


+  "repeater_chanUtil": "频道利用率",
+  "dialog_connectCompanion": "连接伴机以访问中继器和房间服务器功能。",
+  "dialog_disconnectedTitle": "已断开连接",
+  "dialog_disconnectedMessage": "你已与你的伙伴断开连接。",
+  "contact_connectCompanion": "连接至伴侣设备以访问中继器和房间服务器功能。"


+
+  @override
+  String get dialog_disconnectedMessage =>
+      'Je bent verbonden met je companion.';


+  "dialog_connectCompanion": "Povežite se s spremljevalnikom za dostop do funkcij ponavljalnika in strežnika sob.",
+  "dialog_disconnectedTitle": "Prekinjeno",
+  "dialog_disconnectedMessage": "Prekinjena povezava s vašim spre伴ovalcem.",
+  "contact_connectCompanion": "Povežite se s ponсоbnikom za dostop do funkcij pon 반복nika in strežnika prostorov."


+  "dialog_connectCompanion": "Csatlakozzon egy kísérőhöz a ismétlő és szobaszerver funkciók eléréséhez.",
+  "dialog_disconnectedTitle": "Lejárat",
+  "dialog_disconnectedMessage": "Lehentetőtől megszakadtál.",
+  "contact_connectCompanion": "Csatlakozzon egy társhoz az ismpa- és szobaszerver funkciók eléréséhez."


Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 51 out of 51 changed files in this pull request and generated 6 comments.

        // Only add non-empty channels
-        if (!channel.isEmpty) {
+        if (!channel.isEmpty &&
+            _channels.any((c) => c.pskHex != channel.pskHex)) {


+    final lastCompanionPublicKeyHex = prefs.getString(
+      _lastCompanionPublicKeyPref,
+    );
+    if (lastCompanionPublicKeyHex == null ||
+        lastCompanionPublicKeyHex.trim().isEmpty) {
+      return;
+    }
+    _selfPublicKey = hexToPubKey(lastCompanionPublicKeyHex);
+    _setScopedStorePublicKey(lastCompanionPublicKeyHex);
+  }
+


  "dialog_disconnectConfirm": "Are you sure you want to disconnect from this device?",
+  "dialog_disconnectedTitle": "Disconnected",
+  "dialog_disconnectedMessage": "You have been disconnected from your companion.",
+  "dialog_connectCompanion": "Connect to a companion to access repeater and room server features.",


+
+  @override
+  String get dialog_disconnectedMessage =>
+      'Je bent verbonden met je companion.';


+  "dialog_connectCompanion": "Povežite se s spremljevalnikom za dostop do funkcij ponavljalnika in strežnika sob.",
+  "dialog_disconnectedTitle": "Prekinjeno",
+  "dialog_disconnectedMessage": "Prekinjena povezava s vašim spre伴ovalcem.",
+  "contact_connectCompanion": "Povežite se s ponсоbnikom za dostop do funkcij pon 반복nika in strežnika prostorov."


+
+  @override
+  String get dialog_disconnectedMessage =>
+      'Prekinjena povezava s vašim spre伴ovalcem.';


ericszimmermann · 2026-05-15T20:47:18Z

I tested the Pull-request yesterday evening and got some problems: it did not load the channels reliably. Sometimes it showed no channels, and since I also tested to switch companion (I have two) he got them mixed up.
I didn't have problems with the contacts.
I hope you could have another look at this.
Best Regards Eric

zjs81 · 2026-05-15T21:08:57Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3f4e6f4e13

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-05-15T21:11:17Z

+        if (!channel.isEmpty &&
+            _channels.any((c) => c.pskHex != channel.pskHex)) {


Restore adding channels during sync

When a normal channel sync starts, getChannels() clears _channels before requesting channel 0, so this new any(...) predicate is false for the first non-empty channel and remains false for every later expected channel because nothing is ever added. In that connected sync path the app completes with an empty channel list and then caches/saves that empty list, so users lose all channels after connecting or refreshing channels.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-05-15T21:11:17Z

+  Future<void> loadAllCachedDataForCurrentCompanion() async {
+    await loadContactCache();
+    await _loadDiscoveredContactCache();
+    await loadChannelSettings();
+    await loadCachedChannels();
+    await loadAllChannelMessages();
+    await loadUnreadState();


Reload the scoped channel order

When restoreLastCompanionScope() on startup or _setScopedStorePublicKey() after SELF_INFO changes the stores to a companion-specific scope, this helper reloads contacts/channels/messages but not _channelOrder. The only remaining _loadChannelOrder() call runs during initialize() before the scope is set, so saved per-companion channel ordering is ignored until the user reorders channels again.

Useful? React with 👍 / 👎.

zjs81 · 2026-05-26T17:16:12Z

@wel97459 Could you resolve those issues codex found then we can go ahead and merge this?

wel97459 · 2026-05-26T21:58:25Z

Yes, I'll work on it this evening.

…and update disconnection message in Dutch localization

…-offline

Copilot AI review requested due to automatic review settings May 10, 2026 23:08

Copilot started reviewing on behalf of wel97459 May 10, 2026 23:09 View session

wel97459 requested review from 446564 and zjs81 May 10, 2026 23:10

wel97459 force-pushed the dev-offline branch from 094d5d2 to 8ec82f8 Compare May 10, 2026 23:11

Copilot AI reviewed May 10, 2026

View reviewed changes

Comment thread lib/connector/meshcore_connector.dart

Comment thread lib/connector/meshcore_connector.dart

Comment thread lib/screens/channels_screen.dart

Comment thread lib/models/path_history.dart

Comment thread lib/connector/meshcore_connector.dart

chatgpt-codex-connector Bot reviewed May 11, 2026

View reviewed changes

Comment thread lib/connector/meshcore_connector.dart

Comment thread lib/main.dart

Copilot AI review requested due to automatic review settings May 12, 2026 01:00

Copilot started reviewing on behalf of wel97459 May 12, 2026 01:00 View session

Copilot AI reviewed May 12, 2026

View reviewed changes

Comment thread lib/connector/meshcore_connector.dart

Comment thread lib/models/path_history.dart

Comment thread lib/screens/channels_screen.dart

Copilot AI review requested due to automatic review settings May 12, 2026 01:21

wel97459 force-pushed the dev-offline branch from bf59364 to e06f9e9 Compare May 12, 2026 01:21

Copilot started reviewing on behalf of wel97459 May 12, 2026 01:22 View session

Copilot AI reviewed May 12, 2026

View reviewed changes

Comment thread lib/screens/channels_screen.dart

Comment thread lib/screens/channel_chat_screen.dart

Comment thread lib/connector/meshcore_connector.dart

Comment thread lib/models/path_history.dart

wel97459 and others added 10 commits May 12, 2026 17:59

Add byteCount field to PathRecord class with default value

209fee4

Potential fix for pull request finding

c77264c

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

78d08af

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

fix: Initialize _selfPublicKey with lastCompanionPublicKeyHex in Mesh…

247db6a

…CoreConnector

fix: Add byteCount initialization in PathRecord.fromJson method

a270e2e

fix: Improve message key handling and enhance contact tile key unique…

61c8976

…ness

fix: Remove unnecessary whitespace in keyedMessageIds initialization

f0bd611

fix: Enhance channel deduplication logic in loadChannels method

72fea3f

wel97459 force-pushed the dev-offline branch from 4fccfa3 to fa044dd Compare May 13, 2026 01:02

fix: Implement disconnect method in _FakeMeshCoreConnector for TCP an…

01bf95c

…d USB flow tests

Copilot AI review requested due to automatic review settings May 13, 2026 01:21

Copilot started reviewing on behalf of wel97459 May 13, 2026 01:22 View session

Copilot AI reviewed May 13, 2026

View reviewed changes

Potential fix for pull request finding

f4b32e8

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 13, 2026 01:30

Copilot started reviewing on behalf of wel97459 May 13, 2026 01:31 View session

fix: Correct channel addition logic to prevent duplicates based on ps…

e1cc285

…kHex

Copilot AI reviewed May 13, 2026

View reviewed changes

Potential fix for pull request finding

3f4e6f4

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 13, 2026 01:49

Copilot started reviewing on behalf of wel97459 May 13, 2026 01:50 View session

Copilot AI reviewed May 13, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed May 15, 2026

View reviewed changes

wel97459 added 2 commits May 27, 2026 10:26

fix: Improve error handling when restoring last companion public key …

beb3e19

…and update disconnection message in Dutch localization

Merge branch 'dev-offline' of github.com:zjs81/meshcore-open into dev…

ba4fd3e

…-offline

		if (!channel.isEmpty &&
		_channels.any((c) => c.pskHex != channel.pskHex)) {

Conversation

wel97459 commented May 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zjs81 commented May 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

ericszimmermann commented May 15, 2026

Uh oh!

zjs81 commented May 15, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 15, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot May 15, 2026

Choose a reason for hiding this comment

Uh oh!

zjs81 commented May 26, 2026

Uh oh!

wel97459 commented May 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants