Skip to content

Fix styling: active states, focus rings, spinner theming, hairline borders #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skalthoff wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix styling: active states, focus rings, spinner theming, hairline borders #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/common/stylesheets/abstracts/_mixins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,13 @@
}
}

@mixin hairline-border($property: border, $color: currentColor, $width: 0.5px) {
#{$property}: $width solid $color;
@media (resolution: 1dppx) {
#{$property}-width: 1px;
}
}

@mixin popup {
position: absolute;
z-index: $z-index-find-popup;
Expand Down
3 changes: 3 additions & 0 deletions src/common/stylesheets/base/_base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,9 @@ input[type="range"] {
border: 0.5px var(--fill-senary);
box-shadow: 0 1px 0.75px 0 rgba(0, 0, 0, 0.05),
0 0.25px 0.25px 0 rgba(0, 0, 0, 0.15);
@media (resolution: 1dppx) {
border-width: 1px;
}
}

&:active:not(:disabled) {
Expand Down
6 changes: 5 additions & 1 deletion src/common/stylesheets/components/_context-menu.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,16 @@
opacity: 0.5;
}

&:hover, &:focus {
&:hover, &:focus:not(:focus-visible) {
outline: none;
box-shadow: none;
background: var(--fill-quinary);
}

&:active {
background: var(--fill-quarternary);
}

.icon {
display: flex;
align-items: center;
Expand Down
5 changes: 4 additions & 1 deletion src/common/stylesheets/components/_editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,16 @@
background-color: transparent;
border: none;
cursor: pointer;
outline: 0;
vertical-align: middle;
text-align: center;

&:hover {
background-color: var(--fill-quinary);
}

&:active {
background-color: var(--fill-quarternary);
}
}
}
}
Expand Down
6 changes: 6 additions & 0 deletions src/common/stylesheets/components/_modal-popup.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,9 @@
border-radius: 6px;
color: var(--fill-secondary);
border: 0.5px solid transparent;
@media (resolution: 1dppx) {
border-width: 1px;
}
background: unset;
box-shadow: none;
position: relative;
Expand Down Expand Up @@ -379,6 +382,9 @@
background: var(--accent-white);
border: 0.5px solid rgba(0, 0, 0, 0.02);
border-radius: 100px;
@media (resolution: 1dppx) {
border-width: 1px;
}
box-shadow: 0 0.2px 0.25px 0 rgba(0, 0, 0, 0.12);

transition: inset-inline-start $transition;
Expand Down
4 changes: 2 additions & 2 deletions src/common/stylesheets/components/_outline-view.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@
.spinner {
width: 40px;
height: 40px;
border: 4px solid #f3f3f3;
border-top: 4px solid #7e7e7e;
border: 4px solid var(--fill-quinary);
border-top: 4px solid var(--fill-secondary);
border-radius: 50%;
animation: spin1 1.5s linear infinite;
}
Expand Down
4 changes: 4 additions & 0 deletions src/common/stylesheets/components/_toolbar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@
#pageNumber {
width: 52px;
text-align: right;

&:focus {
text-align: left;
}
}

#numPages {
Expand Down
11 changes: 9 additions & 2 deletions src/common/stylesheets/components/_view-popup.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@
.spinner {
width: 16px;
height: 16px;
border: 3px solid #f3f3f3;
border-top: 3px solid #7e7e7e;
border: 3px solid var(--fill-quinary);
border-top: 3px solid var(--fill-secondary);
border-radius: 50%;
animation: spin1 1.5s linear infinite;
}
Expand Down Expand Up @@ -120,6 +120,9 @@
border-radius: 6px;
color: var(--fill-secondary);
border: 0.5px solid transparent;
@media (resolution: 1dppx) {
border-width: 1px;
}

&.active, &:active, &.active-pseudo-class-fix {
background: var(--material-button, #FFFFFF);
Expand All @@ -141,6 +144,10 @@
width: 100%;
color: var(--fill-primary);
height: 22px;

&:active {
background: var(--fill-quarternary);
}
}

.custom-sections {
Expand Down
Loading