Skip to content

Add: select colors in text-selection popup with number keys #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ramonmi wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add: select colors in text-selection popup with number keys #188

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb63972
Add: select colors in text-selection popup with number keys
ramonmi Mar 5, 2026
6f026f8
bind h/u as toggle shortcut
ramonmi Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 31 additions & 1 deletion src/common/keyboard-manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ export class KeyboardManager {

let key = getKeyCombination(event);
let code = getCodeCombination(event);
let textSelectionPopup = this._reader._state.primaryViewSelectionPopup || this._reader._state.secondaryViewSelectionPopup;

let sidebarAnnotationFocused = document.activeElement.classList.contains('annotation');
let readAloudActive = this._reader._state.readAloudState.active;
Expand Down Expand Up @@ -356,6 +357,35 @@ export class KeyboardManager {
}

if (!isTextBox(event.target)) {
if (textSelectionPopup) {
if (key === 'h') {
event.preventDefault();
event.stopPropagation();
this._reader.setTextSelectionAnnotationMode('highlight');
return;
}
else if (key === 'u') {
event.preventDefault();
event.stopPropagation();
this._reader.setTextSelectionAnnotationMode('underline');
return;
}
else if (code.startsWith('Digit')) {
let idx = parseInt(code.slice(5)) - 1;
if (ANNOTATION_COLORS[idx]) {
event.preventDefault();
event.stopPropagation();
this._reader._annotationManager.addAnnotation({
...textSelectionPopup.annotation,
type: this._reader._state.textSelectionAnnotationMode,
color: ANNOTATION_COLORS[idx][1]
});
this._reader.setSelectedAnnotations([]);
return;
}
}
}

if (code === 'Alt-Digit1') {
this._reader.toggleTool('highlight');
}
Expand Down Expand Up @@ -396,7 +426,7 @@ export class KeyboardManager {
this._reader.setTool({ color: ANNOTATION_COLORS[idx][1] });
}
}
else if (this._reader._type === 'pdf' && key === 'h' && !this._reader._state.readAloudState.active) {
else if (this._reader._type === 'pdf' && key === 'h' && !textSelectionPopup && !readAloudActive) {
this._reader.toggleHandTool();
}
else if (this._reader._type === 'pdf' && key === 's') {
Expand Down