Skip to content

fix(PDF): anchor edit-page-number popup to current annotation label #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ramonmi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(PDF): anchor edit-page-number popup to current annotation label #198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/common/reader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2116,8 +2116,15 @@ class Reader {
let currentAnnotation = this._annotationManager._getAnnotationByID(id);
let selectedAnnotations = this._annotationManager._annotations.filter(x => selectedIDs.includes(x.id));
let allAnnotations = this._annotationManager._annotations;
// Get target rect from preview component in the sidebar or a view popup
let labelNode = document.querySelector(`[data-sidebar-annotation-id="${id}"] header .label, .view-popup header .label`);
// Get target rect from the currently visible source: sidebar annotation item
// (when annotations sidebar is active) or the view annotation popup label.
let labelNode;
if (this._state.sidebarOpen && this._state.sidebarView === 'annotations') {
labelNode = document.querySelector(`[data-sidebar-annotation-id="${id}"] header .label`);
}
else {
labelNode = document.querySelector('.annotation-popup header .label');
}
let { left, top, right, bottom } = labelNode.getBoundingClientRect();
let rect = [left, top, right, bottom];
this._updateState({ labelPopup: { currentAnnotation, selectedAnnotations, allAnnotations, rect, selectedIDs, pageLabels } });
Expand Down
Loading