Skip to content

fix(plan): accept empty input as default, fix duplicate -p, add test and warnings#29

Merged
zph merged 1 commit intomainfrom
fix-plan-empty-default-and-duplicate-p
Mar 6, 2026
Merged

fix(plan): accept empty input as default, fix duplicate -p, add test and warnings#29
zph merged 1 commit intomainfrom
fix-plan-empty-default-and-duplicate-p

Conversation

@zph
Copy link
Copy Markdown
Owner

@zph zph commented Mar 6, 2026

  • When user presses Enter at a parameter prompt, treat empty input as
    use default by parsing default in value_proc (fixes JSONDecodeError).
  • Change --prompter short option from -p to -r to avoid conflict with --params.
  • Use datetime.now(timezone.utc) instead of deprecated utcnow().
  • Add regression test that plans with newlines to accept all defaults.
  • Derive prompt count from notebook params so test is robust.
  • Filter pytest deprecation warnings from jupyter_client and papermill.

- Remove duplicate deps in pyproject.toml (bash-kernel, jupyterlab-execute-time)
- Migrate from [tool.poetry.dependencies] to [project.dependencies] (PEP 621)
- Switch build backend from poetry-core to hatchling
- Pin jupytext==1.16.6 for deterministic snapshot tests
- Deno tests now call `uv run runbook` matching CI's hermit shim
- Update test_cli_help for new clear-output command and column alignment
- Update plan test to check parameters tag (current inject behavior)
- Regenerate deno snapshots with pinned jupytext
- Replace Justfile with Makefile (help as default target)
- Update CI workflow to use make instead of just
- Fix plan: accept empty input as default, fix duplicate -p flag
@zph zph force-pushed the fix-plan-empty-default-and-duplicate-p branch from 6daa7ac to 16b6476 Compare March 6, 2026 23:10
@zph zph merged commit b1af053 into main Mar 6, 2026
1 check passed
@zph zph deleted the fix-plan-empty-default-and-duplicate-p branch March 6, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant