fix: scope RBAC permissions and remove unused /dev/mem mount#424
Open
fix: scope RBAC permissions and remove unused /dev/mem mount#424
Conversation
API ClusterRole: - Removed namespaced resources (PVCs, jobs, pods, deployments) — these are already in the namespaced Role or moved there - Kept only cluster-scoped resources: nodes (patch for labeling) and PVs (read-only) - PV permissions reduced from create/delete to read-only API Role (namespaced): - Added PVCs (moved from ClusterRole) - Added pods/log and jobs/status (moved from ClusterRole) DaemonSet: - Removed /dev/mem volume mount — not referenced anywhere in connector source code, unnecessary host memory access Closes #412
lukepolo
reviewed
Apr 2, 2026
| - name: cpu-sys | ||
| mountPath: /host-cpu | ||
| readOnly: true | ||
| - name: mem-sys |
Contributor
There was a problem hiding this comment.
i cant remember why i had this in there....
Contributor
|
overall good, we sure that mem-sys is not being used? |
patchNamespacedDeployment requires patch verb — was in the old ClusterRole but not carried over to the namespaced Role.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
API ClusterRole scoped down to only cluster-scoped resources:
nodes(get/list/patch for game server node labeling) andpersistentvolumes(read-only)API Role (namespaced to 5stack):
persistentvolumeclaims(full CRUD, moved from ClusterRole)pods/log(get) andjobs/status(moved from ClusterRole)DaemonSet:
/dev/memvolume mount — confirmed not referenced anywhere in the connector source code. This was an unnecessary host memory access.Test plan
kustomize buildsucceedsCloses #412