Skip to content

fix: scope RBAC permissions and remove unused /dev/mem mount #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Flegma wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: scope RBAC permissions and remove unused /dev/mem mount #424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2a7ae3
fix: scope RBAC permissions and remove unused /dev/mem mount
Flegma Apr 2, 2026
de02fc3
fix: add missing patch verb on deployments in Role
Flegma Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 2 additions & 36 deletions base/api/rbac/cluster-role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ kind: ClusterRole
metadata:
name: server-creator-clusterrole
rules:
# Nodes are cluster-scoped — patch needed for game server node labeling
- apiGroups:
- ''
resources:
Expand All @@ -11,47 +12,12 @@ rules:
- get
- list
- patch
- apiGroups:
- ''
resources:
- persistentvolumeclaims
verbs:
- create
- get
- list
- watch
- delete
# PVs are cluster-scoped — read-only for monitoring storage
- apiGroups:
- ''
resources:
- persistentvolumes
verbs:
- create
- get
- list
- watch
- delete
- apiGroups:
- batch
resources:
- jobs
- jobs/status
verbs:
- get
- list
- watch
- apiGroups:
- ''
resources:
- pods
- pods/log
verbs:
- get
- list
- watch
- apiGroups:
- apps
resources:
- deployments
verbs:
- patch
18 changes: 18 additions & 0 deletions base/api/rbac/role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,27 @@ rules:
verbs:
- create
- get
- apiGroups:
- ''
resources:
- pods/log
verbs:
- get
- apiGroups:
- ''
resources:
- persistentvolumeclaims
verbs:
- create
- get
- list
- watch
- delete
- apiGroups:
- 'batch'
resources:
- jobs
- jobs/status
verbs:
- create
- get
Expand All @@ -70,4 +87,5 @@ rules:
- get
- list
- watch
- patch
- delete
6 changes: 0 additions & 6 deletions base/game-server-node-connector/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,6 @@ spec:
- name: cpu-sys
mountPath: /host-cpu
readOnly: true
- name: mem-sys
Copy link
Copy Markdown
Contributor

@lukepolo lukepolo Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i cant remember why i had this in there....

mountPath: /host-mem
readOnly: true
volumes:
- name: server-files
hostPath:
Expand Down Expand Up @@ -114,6 +111,3 @@ spec:
- name: cpu-sys
hostPath:
path: /sys/devices/system/cpu/
- name: mem-sys
hostPath:
path: /dev/mem