fix(client): unblock sync when teamserver has no data to send#338
Open
ROCKLEE-1998 wants to merge 1 commit into
Open
fix(client): unblock sync when teamserver has no data to send#338ROCKLEE-1998 wants to merge 1 commit into
ROCKLEE-1998 wants to merge 1 commit into
Conversation
When the teamserver has no packets to synchronize, it still sends SYNC_START (count=0) followed by SYNC_FINISH. The client's count<=0 branch set sync=false and returned, which made the subsequent SYNC_FINISH handler a no-op (it early-returns when !sync). As a result finalizeSyncIfReady() never ran, so the splash screen was never closed and SyncedSignal was never emitted, leaving the client stuck on "data synchronization". Keep sync=true in the count<=0 branch so the incoming SYNC_FINISH properly finalizes the (empty) sync: closes the splash and emits SyncedSignal. Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the teamserver has no packets to synchronize, it still sends
SYNC_START(count=0) followed bySYNC_FINISH. The client'scount <= 0branch inProcessSyncPacket.cppsetsync = falseand returned, which made the subsequentSYNC_FINISHhandler a no-op (it early-returns when!sync). As a resultfinalizeSyncIfReady()never ran, so the splash screen was never closed andSyncedSignalwas never emitted, leaving the client stuck on "data synchronization".This change keeps
sync = truein thecount <= 0branch so the incomingSYNC_FINISHproperly finalizes the (empty) sync: it closes the splash screen and emitsSyncedSignal.Changes
AdaptixClient/Source/Client/ProcessSyncPacket.cpp: in thecount <= 0branch, keepsync = true, reset the batch counters, callsetSyncUpdateUI(false), and initialize the dialog withcountso the upcomingSYNC_FINISHcan finalize.Test plan