Skip to content

fix(client): unblock sync when teamserver has no data to send #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ROCKLEE-1998 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(client): unblock sync when teamserver has no data to send #338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion AdaptixClient/Source/Client/ProcessSyncPacket.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,12 +543,21 @@ void AdaptixWidget::processSyncPacket(QJsonObject jsonObj)
}

if (count <= 0) {
this->sync = false;
// No data to sync, but the server still sends SYNC_FINISH.
// Keep sync=true so the upcoming SYNC_FINISH triggers
// finalizeSyncIfReady(), which closes the splash screen and
// emits SyncedSignal. Setting sync=false here would make the
// SYNC_FINISH handler (which early-returns when !sync) a no-op,
// leaving the client stuck on "data synchronization".
this->sync = true;
this->syncFinishReceived = false;
this->syncTotalBatches = 0;
this->syncProcessingBatchIndex = 0;
this->syncProcessingBatchTotal = 0;
this->syncProcessingBatchProcessed = 0;
this->setSyncUpdateUI(false);
if (dialogSyncPacket)
dialogSyncPacket->init(count);
break;
}

Expand Down