Multitrans: accept initial 200 OK response in addition to 401#2186
Open
neqq3 wants to merge 1 commit intoAlexxIT:masterfrom
Open
Multitrans: accept initial 200 OK response in addition to 401#2186neqq3 wants to merge 1 commit intoAlexxIT:masterfrom
neqq3 wants to merge 1 commit intoAlexxIT:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2185
Some TP-Link IPC (China mainland version) firmware returns
200 OKon the initialMULTITRANSrequest instead of401 Unauthorizedwith a Digest challenge.Current
multitranslogic expects the first response to be401, so these devices fail with:multitrans: expected 401, got 200 OKThis patch keeps the existing flow for cameras that return
401, and adds support for cameras that return200 OKdirectly by continuing with the returned session.Tested on: