Skip to content

Multitrans: accept initial 200 OK response in addition to 401 #2186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neqq3 wants to merge 1 commit into
base: master
Choose a base branch
from
+30 −26
Open

Multitrans: accept initial 200 OK response in addition to 401 #2186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 30 additions & 26 deletions pkg/multitrans/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,39 +117,43 @@ func (c *Client) handshake(u *url.URL) error {
return err
}

if res.StatusCode != http.StatusUnauthorized {
return errors.New("multitrans: expected 401, got " + res.Status)
}

auth := res.Header.Get("WWW-Authenticate")
realm := tcp.Between(auth, `realm="`, `"`)
nonce := tcp.Between(auth, `nonce="`, `"`)
switch res.StatusCode {
case http.StatusUnauthorized:
auth := res.Header.Get("WWW-Authenticate")
realm := tcp.Between(auth, `realm="`, `"`)
nonce := tcp.Between(auth, `nonce="`, `"`)

// Step 2: Send Auth
user := u.User.Username()
pass, _ := u.User.Password()
// Step 2: Send Auth
user := u.User.Username()
pass, _ := u.User.Password()

ha1 := tcp.HexMD5(user, realm, pass)
ha2 := tcp.HexMD5("MULTITRANS", uri)
response := tcp.HexMD5(ha1, nonce, ha2)
ha1 := tcp.HexMD5(user, realm, pass)
ha2 := tcp.HexMD5("MULTITRANS", uri)
response := tcp.HexMD5(ha1, nonce, ha2)

authHeader := fmt.Sprintf(`Digest username="%s", realm="%s", nonce="%s", uri="%s", response="%s"`,
user, realm, nonce, uri, response)
authHeader := fmt.Sprintf(`Digest username="%s", realm="%s", nonce="%s", uri="%s", response="%s"`,
user, realm, nonce, uri, response)

data = fmt.Sprintf("MULTITRANS %s RTSP/1.0\r\nCSeq: 1\r\nAuthorization: %s\r\nX-Client-UUID: %s\r\n\r\n",
uri, authHeader, uid)
data = fmt.Sprintf("MULTITRANS %s RTSP/1.0\r\nCSeq: 1\r\nAuthorization: %s\r\nX-Client-UUID: %s\r\n\r\n",
uri, authHeader, uid)

if _, err = c.conn.Write([]byte(data)); err != nil {
return err
}
if _, err = c.conn.Write([]byte(data)); err != nil {
return err
}

res, err = tcp.ReadResponse(c.rd)
if err != nil {
return err
}
res, err = tcp.ReadResponse(c.rd)
if err != nil {
return err
}

if res.StatusCode != http.StatusOK {
return errors.New("multitrans: auth failed: " + res.Status)
if res.StatusCode != http.StatusOK {
return errors.New("multitrans: auth failed: " + res.Status)
}
case http.StatusOK:
// Some TP-Link CN firmware skips the Digest challenge and
// immediately returns 200 plus Session on the first MULTITRANS.
default:
return errors.New("multitrans: expected 401 or 200, got " + res.Status)
}

// Session: 7116520596809429228
Expand Down