Conversation
|
CI test fails because this PR uses |
|
No reason in particular. I don't mind bumping the minimum Rust version up. However I'm not sure about replacing the mutex with what is effectively a spin lock. Do you have a reason for wanting to avoid a mutex here? |
|
Hmm, I just assumed that I first thought that the redundancy of the mutex and By the way, just for curiosity :) can I ask why this repo is separate from your |
|
It's not really a performance reason, it's just that the seqlock only works when there is a single writer at a time. I generally prefer proper mutexes over spinlocks because it avoids issues when a thread is descheduled while holding a lock.
Again, no real reason. It just didn't feel like a proper part of |
This PR removes dependence on another mutex, and instead use the
seq: AtomicUsizevariable inSeqlockas the mutex variable.