Skip to content

fix(api-axios): override getUrl in AvStashApi to support get by id#990

Merged
jordan-a-young merged 2 commits into
masterfrom
feat/stash-launch
May 28, 2026
Merged

fix(api-axios): override getUrl in AvStashApi to support get by id#990
jordan-a-young merged 2 commits into
masterfrom
feat/stash-launch

Conversation

@btrinhav
Copy link
Copy Markdown
Contributor

Stash API only has GET by ID

@gregmartDOTin
Copy link
Copy Markdown
Contributor

Is this necessary? it seems like the existing getUrl logic supports this already.

@jordan-a-young
Copy link
Copy Markdown
Member

Instead of overriding getUrl I think we can change the way the url is built to use the existing logic. Something like

super({
      path: 'cloud/web/appl/stash',
      name: 'session/data',
      ...config,
});

This should build the desired url and pass the unit test

@jordan-a-young jordan-a-young merged commit 8a9e5a5 into master May 28, 2026
6 checks passed
@jordan-a-young jordan-a-young deleted the feat/stash-launch branch May 28, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants